Added token generation compatibility for Linux & MacOS #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linux and MacOS use UTF-8 rather than Windows Powershell UTF-16. Due to the extra null bytes from UTF-16, password conversion from SecureString to plaintext was terminating after the first character on Linux. This commit adds a check to determine if the host system is Windows or Linux/MacOS. If Windows, the original logic runs. If Linux or MacOS, a different method for converting a SecureString to plaintext is performed.
UpperM
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux and MacOS use UTF-8 rather than Windows Powershell UTF-16. Due to the extra null bytes from UTF-16, password conversion from SecureString to plaintext was terminating after the first character on Linux. This commit adds a check to determine if the host system is Windows or Linux/MacOS. If Windows, the original logic runs. If Linux or MacOS, a different method for converting a SecureString to plaintext is performed.