Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix constructor from rows, cols, Buffer, step #23

Merged
merged 2 commits into from
Apr 22, 2022

Conversation

piercus
Copy link
Collaborator

@piercus piercus commented Apr 19, 2022

@UrielCh
Copy link
Owner

UrielCh commented Apr 20, 2022

For this kind of change, I think that you should add a test in tests/core/Mat/constructorTestsFromFillVector.ts or tests/core/Mat/constructorTestsFromJsArray.ts

Please do it before I enforce "noImplicitAny": true in the tests (currently Found 553 errors.).

@piercus
Copy link
Collaborator Author

piercus commented Apr 21, 2022

@UrielCh please review

@UrielCh
Copy link
Owner

UrielCh commented Apr 22, 2022

leave it to appveyor :)

@UrielCh UrielCh merged commit 1b431d6 into UrielCh:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants