fix: add support for serializing DateTime from ISO date string #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
cfnelson
approved these changes
Jul 26, 2018
src/DateTime.js
Outdated
| } | ||
|
|
||
| // eslint-disable-next-line no-restricted-globals | ||
| if (isNaN(value.getTime())) { | ||
| throw new TypeError(`Value is not a valid Date: ${value}`); | ||
| if (isNaN(v.getTime())) { |
There was a problem hiding this comment.
Potential suggestion:
Might be safer to use Number.isNaN() here. I doubt the situation would ever occur were NaN is returned but Number.isNan() is the newer/safer check instead of the global isNaN() and would get rid of your eslint-disable-next-line.
Details here -> https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isNaN
vespertilian
pushed a commit
to vespertilian/graphql-scalars
that referenced
this pull request
Oct 2, 2020
fix: add support for serializing DateTime from ISO date string
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.