Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ua postal code #1850

Merged
merged 2 commits into from
Mar 24, 2023
Merged

feat: add ua postal code #1850

merged 2 commits into from
Mar 24, 2023

Conversation

VoloshchenkoAl
Copy link
Contributor

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Description

This PR adds a new regex for the Ukrainian postal code in the PostalCode scalar.

Refferance: https://en.wikipedia.org/wiki/Postal_codes_in_Ukraine

Ukraine uses five-digit numeric postal codes that are written immediately to the right of the city or settlement name.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@ardatan ardatan merged commit ea80093 into Urigo:master Mar 24, 2023
@theguild-bot theguild-bot mentioned this pull request Apr 24, 2023
37 tasks
@theguild-bot theguild-bot mentioned this pull request Oct 26, 2023
36 tasks
@theguild-bot theguild-bot mentioned this pull request Feb 5, 2024
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants