fix: use url constructor instead of templating and optimise filtering

UselessStudio · Oct 6, 2023 · 74dcd23 · 74dcd23
1 parent bc5228c
commit 74dcd23
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/managers/storage.tsx b/src/managers/storage.tsx
@@ -122,12 +122,14 @@ export const StorageManagerProvider: FC<PropsWithChildren> = ({children}) => {
         const param = window.Telegram.WebApp.initDataUnsafe.start_param;
         if(!param) return;
 
-        const accounts = decodeGoogleAuthenticator(`otpauth-migration://offline?data=${param}`);
+        const url = new URL("otpauth-migration://offline");
+        url.searchParams.set("data", param)
+        const accounts = decodeGoogleAuthenticator(url.toString());
         if(!accounts) return;
 
-        storageManager.saveAccounts(accounts.filter(account => !Object.values(storageManager.accounts)
-            .map(a => a.uri)
-            .includes(account.uri)));
+        const uris = Object.values(storageManager.accounts).map(a => a.uri);
+
+        storageManager.saveAccounts(accounts.filter(account => !uris.includes(account.uri)));
         setImported(true);
     }, [ready, imported, storageManager]);