Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): Implement Domain package (Gno Name Service) #9

Merged
merged 20 commits into from
Sep 10, 2024

Conversation

linhpn99
Copy link
Collaborator

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@linhpn99 linhpn99 changed the title Define GNS package feat(examples): Implement GNS (Gno Name Service) Aug 11, 2024
@linhpn99 linhpn99 changed the title feat(examples): Implement GNS (Gno Name Service) feat(examples): Implement Domain package (Gno Name Service) Aug 11, 2024
Copy link

sonarcloud bot commented Aug 11, 2024

@thinhnx-var thinhnx-var changed the base branch from master to dev-thinhnx/gno-naming-service August 12, 2024 02:11
@thinhnx-var
Copy link
Collaborator

@linhpn99 changed base branch to feature branch, then we can make the pull request to master repo without refactor our master br. 🚀

@linhpn99
Copy link
Collaborator Author

@linhpn99 changed base branch to feature branch, then we can make the pull request to master repo without refactor our master br. 🚀

This PR is just an announcement about the feature being developed/nearing completion

@linhpn99
Copy link
Collaborator Author

linhpn99 commented Aug 12, 2024

We will create a PR to the master branch of Gno along with your realms @thinhnx-var

@thinhnx-var
Copy link
Collaborator

@linhpn99 yeah, and this way is easier for squash and merge the commit. gno-core-team <- Var-gno/dev-feature <- this define-gns <- commit to this. Then the history should look so good and clean.

@thinhnx-var thinhnx-var merged commit f3bfc60 into dev-thinhnx/gno-naming-service Sep 10, 2024
40 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants