Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v490.9 dev1 - improve selection of images on mscw stage; bug fix in event selection for dispAnalyzer #254

Merged
merged 20 commits into from
Apr 18, 2024

Conversation

GernotMaier
Copy link
Member

@GernotMaier GernotMaier commented Jan 13, 2024

NOTE: wrong branch name, this is v490.9

This pull requests introduces changes related to the selection of images for the stereo reconstruction on the mscw_energy stage. Goal is to allow a looser image selection for the stereo reconstruction on the mscw_energy stage compared to evndisp:

  • in evndisp, images are selected according to the settings in the reconstruction parameter file (e.g., see here)
  • in mscw_energy, images can be removed from the stereo reconstruction by e.g., a --maxloss=0.2 command line parameter.
  • image selection and number of images in reconstructed are now correctly updated after redoing the stereo reconstruction with disp

This pull request allows now that mscw_energy uses looser cuts. For this, add the command line parameter -use_evndisp_selected_images=0.

Additional changes:

  • bug fix in setting quality cuts for angular disp analysed (fui was not set correctly; this does not have any impact unless one uses very loose (>0.9) loss cuts
  • simplified settings of quality cuts (including loss) for trainTMVAforAngularReconstruction

@GernotMaier GernotMaier self-assigned this Jan 13, 2024
@GernotMaier GernotMaier changed the title v490.5 dev1 - improve selection of images on mscw stage; bug fix in event selection for dispAnalyzer v490.6 dev1 - improve selection of images on mscw stage; bug fix in event selection for dispAnalyzer Jan 14, 2024
@GernotMaier GernotMaier changed the title v490.6 dev1 - improve selection of images on mscw stage; bug fix in event selection for dispAnalyzer v490.9 dev1 - improve selection of images on mscw stage; bug fix in event selection for dispAnalyzer Apr 16, 2024
@GernotMaier GernotMaier marked this pull request as ready for review April 18, 2024 08:59
@GernotMaier GernotMaier merged commit c7a7e2f into main Apr 18, 2024
5 checks passed
@GernotMaier GernotMaier deleted the v490.5-dev1 branch April 18, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant