Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] В модалках не работают внутренние скроллы #335

Closed
fedorov-xyz opened this issue Jul 31, 2019 · 7 comments · Fixed by #7325 or #6759
Closed

[Bug] В модалках не работают внутренние скроллы #335

fedorov-xyz opened this issue Jul 31, 2019 · 7 comments · Fixed by #7325 or #6759
Assignees
@inomdzhon
Labels
cmp:modal type:bug
Milestone
v7.0.0

Comments

@fedorov-xyz
Copy link
Contributor

fedorov-xyz commented Jul 31, 2019 •
edited
Loading

Актуально для HorizontalScroll, Input и тач-событий.
@fedorov-xyz fedorov-xyz self-assigned this Jul 31, 2019
@serginij serginij mentioned this issue May 26, 2020
Closed
This was referenced Dec 10, 2020
Closed
Closed
Closed
Closed
thoughtspile added a commit that referenced this issue Dec 10, 2020
@thoughtspile
#335: Enable scrolling inside modals
5c85c93
@gbowsky gbowsky mentioned this issue Jan 21, 2021
Merged
@gbowsky gbowsky reopened this Apr 26, 2021
@fax1ty
Copy link

fax1ty commented Jun 23, 2021

Что со скроллом в модалках на данный момент? Вижу коммит который должен был это исправить. Но даже с использованием дополнительных свойств на данный момент (у меня) не работает HorizontalScroll внутри ModalPage.

@hoxtonhero
Copy link

Что со скроллом в модалках на данный момент? Вижу коммит который должен был это исправить. Но даже с использованием дополнительных свойств на данный момент (у меня) не работает HorizontalScroll внутри ModalPage.

Есть какие-то новости?)

@ArthurStam
Copy link
Contributor

Планируем исправить в ближайшие месяцы

@egorprnn egorprnn mentioned this issue Nov 21, 2021
Closed
@SevereCloud SevereCloud added this to VKUI Aug 1, 2022
@SevereCloud SevereCloud moved this to Backlog in VKUI Aug 1, 2022
@slevamatveev
Copy link

Есть какие новости по фиксу? HorizontalScroll до сих пор не работает (без мышки на мобильном устройстве, по крайней мере)

@SevereCloud
Copy link
Contributor

Скорее всего будем переделывать модальные окна полностью

@SevereCloud SevereCloud mentioned this issue May 18, 2023
Closed
@SevereCloud SevereCloud removed their assignment Jul 28, 2024
@inomdzhon inomdzhon self-assigned this Aug 5, 2024
@inomdzhon inomdzhon moved this from 🗃 Backlog to 🔜 To do in VKUI Aug 5, 2024
@inomdzhon inomdzhon moved this from 🔜 To do to 🔧 In progress in VKUI Aug 5, 2024
@inomdzhon inomdzhon mentioned this issue Aug 6, 2024
Merged
@inomdzhon inomdzhon added this to the v6.5.0 milestone Aug 6, 2024
@github-project-automation github-project-automation bot moved this from 🔧 In progress to ✅ Done in VKUI Aug 6, 2024
@vkcom-publisher
Copy link
Contributor

✅ v6.5.0 🎉

@inomdzhon inomdzhon mentioned this issue Sep 30, 2024
Merged
8 tasks
@inomdzhon inomdzhon changed the title В модалках не работают внутренние скроллы [Bug] В модалках не работают внутренние скроллы Oct 1, 2024
@inomdzhon inomdzhon reopened this Oct 1, 2024
@inomdzhon inomdzhon modified the milestones: v6.5.0, v7.0.0 Nov 28, 2024
@inomdzhon inomdzhon moved this from ✅ Done to 👀 In Review in VKUI Nov 28, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Dec 2, 2024
@vkcom-publisher
Copy link
Contributor

✅ v7.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@inomdzhon inomdzhon

Labels
cmp:modal type:bug
Projects
VKUI
Archived in project
Milestone
v7.0.0
Development

Successfully merging a pull request may close this issue.

fix(ModalRoot): rm preventTouch() VKCOM/VKUI
refactor: ModalRoot/ModalPage/ModalCard VKCOM/VKUI
9 participants
@ArthurStam @inomdzhon @SevereCloud @hoxtonhero @fedorov-xyz @fax1ty @gbowsky @slevamatveev @vkcom-publisher