Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Typography]: Экспортировать наружу TypographyProps #6400

Closed
egorprnn opened this issue Jan 18, 2024 · 1 comment · Fixed by #6435
Closed

[Feature][Typography]: Экспортировать наружу TypographyProps #6400

egorprnn opened this issue Jan 18, 2024 · 1 comment · Fixed by #6435
Assignees
@SevereCloud
Labels
cmp:typography type:feature
Milestone
v6.1.0

Comments

@egorprnn
Copy link
Contributor

egorprnn commented Jan 18, 2024 •
edited
Loading

Описание

При создании компонентов, которые завязаны на компоненты типографики используем ComponentType<TypographyProps>, чтобы ограничить передаваемый компонент внешне.

Снимок экрана 2024-01-18 в 13 02 39

Сейчас этот тип не экспортируется наружу библиотеки - приходится обращаться напрямую к файлу, в котором находится этот интерфейс.
@mendrew mendrew added this to VKUI Jan 18, 2024
@github-project-automation github-project-automation bot moved this to 🗃 Backlog in VKUI Jan 18, 2024
@SevereCloud SevereCloud self-assigned this Jan 22, 2024
@SevereCloud SevereCloud added this to the v6.1.0 milestone Jan 22, 2024
SevereCloud added a commit that referenced this issue Jan 22, 2024
@SevereCloud
feat: export TypographyProps
b137be5 
- closed #6400
@SevereCloud SevereCloud moved this from 🗃 Backlog to 👀 In Review in VKUI Jan 22, 2024
@SevereCloud SevereCloud mentioned this issue Jan 22, 2024
Merged
SevereCloud added a commit that referenced this issue Jan 23, 2024
@SevereCloud
feat: export TypographyProps (#6435)
3dd1fcb 
- closed #6400
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Jan 23, 2024
@vkcom-publisher
Copy link
Contributor

✅ v6.1.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SevereCloud SevereCloud

Labels
cmp:typography type:feature
Projects
VKUI
Archived in project
Milestone
v6.1.0
Development

Successfully merging a pull request may close this issue.

feat: export TypographyProps VKCOM/VKUI
4 participants
@mendrew @SevereCloud @egorprnn @vkcom-publisher