Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Уменьшить отступ между Group и увеличить border-radius #6700

Closed
mendrew opened this issue Mar 15, 2024 · 2 comments · Fixed by #6769
Closed

[Feature]: Уменьшить отступ между Group и увеличить border-radius #6700

mendrew opened this issue Mar 15, 2024 · 2 comments · Fixed by #6769
Assignees
@BlackySoul
Labels
cmp:group type:feature
Milestone
v6.1.0

Comments

@mendrew
Copy link
Contributor

mendrew commented Mar 15, 2024

Описание

Необходимо привести Group к виду который чаще всего используется дизайнерами.

На данный момент вместо 16px расстояние между Group рисуют 8px. А border-radius используют 20px вместо 12px.
Такой вид используется в VK Знакомствах и на m.vk

Вопрос был поднят тут: #6607 (comment)

Дизайнеры VKUI подтвердили, что следует перейти к такому варианту и дизайн в дизайн-системе тоже обновится.

Скриншоты

No response
@mendrew mendrew added this to VKUI Mar 15, 2024
@github-project-automation github-project-automation bot moved this to 🗃 Backlog in VKUI Mar 15, 2024
@BlackySoul BlackySoul self-assigned this Mar 28, 2024
@BlackySoul BlackySoul moved this from 🗃 Backlog to 🔧 In progress in VKUI Mar 28, 2024
@BlackySoul BlackySoul added this to the v6.1.0 milestone Mar 28, 2024
@Zaycevq
Copy link

Zaycevq commented Mar 28, 2024

Скругление для Compact режима компонента Group должен остаться 12px. Мобильная (Regular) версия 20px

@BlackySoul BlackySoul mentioned this issue Mar 28, 2024
Merged
2 tasks
@BlackySoul BlackySoul linked a pull request Mar 28, 2024 that will close this issue
feat(Group): new token for border-radius on mobile + spacing 8px #6769
Merged
2 tasks
@BlackySoul BlackySoul moved this from 🔧 In progress to 👀 In Review in VKUI Apr 1, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI May 3, 2024
@vkcom-publisher
Copy link
Contributor

✅ v6.1.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BlackySoul BlackySoul

Labels
cmp:group type:feature
Projects
VKUI
Archived in project
Milestone
v6.1.0
Development

Successfully merging a pull request may close this issue.

feat(Group): new token for border-radius on mobile + spacing 8px VKCOM/VKUI
4 participants
@mendrew @BlackySoul @vkcom-publisher @Zaycevq