Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Group): new token for border-radius on mobile + spacing 8px #6769

Merged
merged 5 commits into from
May 3, 2024

Conversation

BlackySoul
Copy link
Contributor

@BlackySoul BlackySoul commented Mar 28, 2024


  • e2e-тесты
  • Дизайн-ревью

Описание

См. подробное описание в задаче

Изменения

  • на мобилках уточняем новый токен для скруглений - --vkui--size_border_radius_promo--regular
  • меняем отступ между группами на 8px

Copy link
Contributor

github-actions bot commented Mar 28, 2024

size-limit report 📦

Path Size
JS 360.22 KB (-0.01% 🔽)
JS (gzip) 109.5 KB (-0.01% 🔽)
JS (brotli) 90.13 KB (-0.19% 🔽)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 262.23 KB (+0.19% 🔺)
CSS (gzip) 34.44 KB (+0.23% 🔺)
CSS (brotli) 27.87 KB (+0.15% 🔺)

Copy link

codesandbox-ci bot commented Mar 28, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Mar 28, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Mar 28, 2024

👀 Docs deployed

Commit 00354e2

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.43%. Comparing base (61a03f4) to head (00354e2).
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6769      +/-   ##
==========================================
- Coverage   82.43%   82.43%   -0.01%     
==========================================
  Files         339      339              
  Lines       10395    10394       -1     
  Branches     3475     3475              
==========================================
- Hits         8569     8568       -1     
  Misses       1826     1826              
Flag Coverage Δ
unittests 82.43% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mendrew
mendrew previously approved these changes Mar 29, 2024
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vkcom-publisher vkcom-publisher added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Apr 5, 2024
SevereCloud
SevereCloud previously approved these changes Apr 8, 2024
@BlackySoul BlackySoul dismissed stale reviews from SevereCloud and mendrew via 16d48dd April 15, 2024 05:52
@BlackySoul BlackySoul force-pushed the feat/6700/Group_sync_with_design branch from cd9c0bc to 16d48dd Compare April 15, 2024 05:52
@BlackySoul BlackySoul force-pushed the feat/6700/Group_sync_with_design branch from 8d22bb5 to 00354e2 Compare April 18, 2024 04:44
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@Zaycevq Zaycevq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Apr 30, 2024
@BlackySoul BlackySoul removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label May 2, 2024
@BlackySoul BlackySoul merged commit ffacf13 into master May 3, 2024
26 checks passed
@BlackySoul BlackySoul deleted the feat/6700/Group_sync_with_design branch May 3, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Уменьшить отступ между Group и увеличить border-radius
7 participants