Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] ActionSheet: контекстный режим #906

Closed
Lihachyov opened this issue Jul 22, 2020 · 1 comment · Fixed by #5829
Closed

[Feature] ActionSheet: контекстный режим #906

Lihachyov opened this issue Jul 22, 2020 · 1 comment · Fixed by #5829
Assignees
@SevereCloud
Labels
cmp:action-sheet type:feature
Milestone
v5.9.0

Comments

@Lihachyov
Copy link

В V4 ActionSheet переключается в контекстный режим при Regular Width.
Предложение: добавить свойство mode: sheet (default) | contextual, давая возможность переключать и форсить режим самостоятельно.

По умолчанию на Compact Width включается mode sheet, при Regular Width будет включаться mode contextual, но его можно будет форсить и на узких экранах и наоборот.
@NekR NekR added the v4 label Jul 22, 2020
@ArthurStam ArthurStam removed the v4 label Mar 31, 2021
@SevereCloud SevereCloud moved this to Backlog in VKUI Aug 1, 2022
@SevereCloud SevereCloud added this to VKUI Aug 1, 2022
@SevereCloud SevereCloud self-assigned this Sep 19, 2023
@SevereCloud SevereCloud added this to the v5.10.0 milestone Sep 19, 2023
SevereCloud added a commit that referenced this issue Sep 19, 2023
@SevereCloud
feat(ActionSheet): add mode
3d136ce 
- closed #906
@SevereCloud SevereCloud mentioned this issue Sep 19, 2023
Merged
1 task
SevereCloud added a commit that referenced this issue Sep 19, 2023
@SevereCloud
feat(ActionSheet): add mode (#5829)
f062e60 
- closed #906
@github-project-automation github-project-automation bot moved this from 🗃 Backlog to ✅ Done in VKUI Sep 19, 2023
@SevereCloud SevereCloud modified the milestones: v5.10.0, v5.9.0 Sep 19, 2023
vkcom-publisher pushed a commit that referenced this issue Sep 19, 2023
@SevereCloud @actions-user
feat(ActionSheet): add mode (#5829)
1890a41 
- closed #906
@vkcom-publisher
Copy link
Contributor

✅ v5.9.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SevereCloud SevereCloud

Labels
cmp:action-sheet type:feature
Projects
VKUI
Archived in project
Milestone
v5.9.0
Development

Successfully merging a pull request may close this issue.

feat(ActionSheet): add mode VKCOM/VKUI
7 participants
@NekR @Lihachyov @ArthurStam @thoughtspile @SevereCloud @eugpoloz @vkcom-publisher