Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ModalRoot: responding to viewport changes #1490

Merged
merged 3 commits into from
Mar 29, 2021
Merged

ModalRoot: responding to viewport changes #1490

merged 3 commits into from
Mar 29, 2021

Conversation

gbowsky
Copy link
Contributor

@gbowsky gbowsky commented Mar 24, 2021 •
edited
Loading

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2021 •
edited
Loading

size-limit report 📦

Path Size
JS 46.1 KB (+0.16% 🔺)
JS, unstable 6.89 KB (0%)
CSS 27.42 KB (0%)
CSS, unstable 468 B (0%)

@github-actions
Copy link
Contributor

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/1490/

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2021 •
edited
Loading

Code coverage

lines1993 / 341558.36%
statements2017 / 348757.84%
functions436 / 77856.04%
branches1099 / 259342.38%

Generated by 🚫 dangerJS against 622ce01

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 24, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 622ce01:

Sandbox Source
VKUI - default example Configuration

@gbowsky gbowsky changed the title fix(ModalRoot): updating translate on viewport height changes fix(ModalRoot): responding on viewport changes Mar 24, 2021
@gbowsky gbowsky changed the title fix(ModalRoot): responding on viewport changes ModalRoot: responding on viewport changes Mar 24, 2021
@gbowsky gbowsky changed the title ModalRoot: responding on viewport changes ModalRoot: responding to viewport changes Mar 24, 2021
@gbowsky gbowsky marked this pull request as ready for review March 24, 2021 15:11
@gbowsky gbowsky requested a review from a team as a code owner March 24, 2021 15:11
@ewgenius ewgenius merged commit eb715a2 into master Mar 29, 2021
@ewgenius ewgenius deleted the fix/modals_resize_handling branch March 29, 2021 09:33
@mclaran mclaran mentioned this pull request Aug 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eolme eolme eolme left review comments

@ewgenius ewgenius ewgenius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gbowsky @ewgenius @eolme