Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ModalRoot): Исправляет скролл при touch-событиях #3339

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

@BlackySoul BlackySoul requested a review from a team as a code owner September 23, 2022 10:17
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 258.09 KB (-0.21% 🔽)
JS (gzip) 77.57 KB (-0.19% 🔽)
JS (brotli) 65.53 KB (+0.08% 🔺)
JS, unstable 31.58 KB (0%)
CSS 290.99 KB (0%)
CSS (gzip) 39.29 KB (0%)
CSS (brotli) 31.21 KB (0%)
CSS, unstable 1.22 KB (0%)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5d68424:

Sandbox Source
VKUI - default example Configuration

@github-actions
Copy link
Contributor

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/3339/

@github-actions
Copy link
Contributor

Warnings
⚠️

24 changed screenshots found — review & update them via "Update Screenshots" action before merging.

Changed screenshots

actionsheet-ios-dark-w_2-1
actionsheet-vkcom-dark-w_2-1
alert-vkcom-dark-1
button-vkcom-dark-1
calendar-vkcom-dark-1
card-vkcom-dark-1
cardscroll-vkcom-dark-1
chipsinput-vkcom-dark-1
contentcard-vkcom-dark-1
customselect-vkcom-dark-1
dateinput-vkcom-dark-1
daterangeinput-vkcom-dark-1
formitem-vkcom-dark-1
formlayoutgroup-vkcom-dark-1
input-vkcom-dark-1
modalcard-vkcom-dark-1
modalpageheader-vkcom-dark-w_2-1
modalpageheader-vkcom-dark-w_5-1
nativeselect-vkcom-dark-1
richcell-vkcom-dark-1
selectmimicry-vkcom-dark-1
subnavigationbutton-vkcom-dark-1
tabs-vkcom-dark-1
textarea-vkcom-dark-1

Code coverage

lines3858 / 495177.92%
statements3928 / 505077.78%
functions835 / 106578.40%
branches3614 / 497972.58%
branchesTrue0 / 0100.00%

Generated by 🚫 dangerJS against 5d68424

Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не хватает issue 👉👈

@BlackySoul BlackySoul added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
None yet
2 participants