fix(SubnavigationBar): combining buttons into a list [a11y] #5225

scffs · 2023-06-11T10:06:06Z

fixes [Enhancement][a11y][SubnavigationBar]: Улучшить доступность SubnavigationBar #5023

Не уверен насчет правильности решения, в доке SubnavigationButton используется без SubnavigationBar, поэтому возникает это (li внутри div)

UPD
В одном из своих проектов у меня есть такой же самописный компонент, в нём такая логика, попробую позже что-то типа такого же реализовтаь. (Children#children-toarray)

UPD
Сделал в этом коммите

a11y тесты теперь не падают, ура

UPD
Немного сломались стили, теперь margin-left не срабатывает

UPD
Как-то пофиксил стили, но скорее всего там ещё надо будет что-то менять...

This reverts commit 8494645.

…ned into a list Signed-off-by: scffs <khidey@inbox.ru>

Signed-off-by: scffs <khidey@inbox.ru>

This reverts commit 9ff5698.

codesandbox-ci · 2023-06-11T10:08:58Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 24882e8:

Sandbox	Source
VKUI TypeScript	Configuration

codecov · 2023-06-11T10:10:24Z

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (9e8f40f) 81.70% compared to head (24882e8) 81.66%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5225      +/-   ##
==========================================
- Coverage   81.70%   81.66%   -0.04%     
==========================================
  Files         283      285       +2     
  Lines        9476     9555      +79     
  Branches     3013     3050      +37     
==========================================
+ Hits         7742     7803      +61     
- Misses       1734     1752      +18

Flag	Coverage Δ
a11ytests	`?`
unittests	`81.66% <0.00%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...c/components/SubnavigationBar/SubnavigationBar.tsx	`80.95% <0.00%> (-4.77%)`	⬇️

... and 33 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

github-actions · 2023-06-11T10:10:35Z

size-limit report 📦

Path	Size
JS	311.33 KB (+0.03% 🔺)
JS (gzip)	91.03 KB (+0.02% 🔺)
JS (brotli)	75.53 KB (+0.02% 🔺)
JS import Div (tree shaking)	2.97 KB (0%)
CSS	272.91 KB (+0.01% 🔺)
CSS (gzip)	35.7 KB (+0.02% 🔺)
CSS (brotli)	28.29 KB (+0.07% 🔺)

github-actions · 2023-06-11T10:11:11Z

👀 Docs deployed

Commit 24882e8

packages/vkui/src/components/SubnavigationBar/SubnavigationBar.module.css

github-actions · 2023-06-11T10:17:58Z

e2e tests

Playwright Report

…ponent="li"` props in `Tappable` Signed-off-by: scffs <khidey@inbox.ru>

Signed-off-by: scffs <khidey@inbox.ru>

packages/vkui/src/components/SubnavigationBar/SubnavigationBar.module.css

….module.css Co-authored-by: Daniil Suvorov <severecloud@gmail.com>

packages/vkui/src/components/SubnavigationBar/SubnavigationBar.module.css

….module.css Co-authored-by: Daniil Suvorov <severecloud@gmail.com>

packages/vkui/src/components/SubnavigationBar/SubnavigationBar.module.css

unset ломает верстку Co-authored-by: Daniil Suvorov <severecloud@gmail.com>

github-actions · 2023-07-07T10:04:33Z

PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно.

packages/vkui/src/components/SubnavigationButton/SubnavigationButton.module.css

Signed-off-by: scffs <khidey@inbox.ru>

packages/vkui/src/components/SubnavigationButton/SubnavigationButton.module.css

packages/vkui/src/components/SubnavigationBar/SubnavigationBar.tsx

This reverts commit 4a5a80a.

Signed-off-by: scffs <khidey@inbox.ru>

scffs · 2023-07-13T09:33:16Z

Из-за этого я подумал, что это уже удалить надо сейчас)

P.S. Типа красный цвет все дела)

inomdzhon

👍

inomdzhon · 2023-07-13T09:42:35Z

@scffs добавишь плиз в задачу #5023 коммент со своей ссылкой на твой профиль ВКонтакте 🙏 Заодно смогу заасайнить тебя. Отметил задачу как 🔥 fix bounty

vkcom-publisher · 2023-07-17T07:44:51Z

⚠️ Patch (forked repo)

Необходимо вручную перенести исправление в стабильную ветку.

Дальнейшие действия выполняют контрибьютеры из группы @VKCOM/vkui-core

Чтобы исправление попало в стабильную ветку, выполните следующие действия:

Создайте новую ветку от стабильной и примените исправления используя cherry-pick

git stash # опционально
git fetch origin 5.6-stable
git checkout -b patch/pr5225 origin/5.6-stable

git cherry-pick --no-commit ccfb8e4a539784ddb9d62ce0b22c228c3c73e9dd
git checkout HEAD **/__image_snapshots__/*.png
git diff --quiet HEAD || git commit --no-verify --no-edit

Исправьте конфликты, следуя инструкциям из терминала
Отправьте ветку на GitHub и создайте новый PR с последней стабильной веткой (метка patch не нужна)

git push --set-upstream origin patch/pr5225
gh pr create --base 5.6-stable --title "patch: pr5225" --body "- patch #5225"

* fix(Popover): fix incorrect words ending * Revert "doc(Popover): incorrect declension of two words" This reverts commit 8494645. * fix(SubnavigationBar): the `SubnavigationButton` components are combined into a list Signed-off-by: scffs <khidey@inbox.ru> * fix(SubnavigationBar): getting rid of the extra div Signed-off-by: scffs <khidey@inbox.ru> * Revert "Revert "doc(Popover): incorrect declension of two words"" This reverts commit 9ff5698. * fix(SubnavigationBar): using `React.Children.toArray` instead of `Component="li"` props in `Tappable` Signed-off-by: scffs <khidey@inbox.ru> * fix(SubnavigationBar): added `key` Signed-off-by: scffs <khidey@inbox.ru> * fix(SubnavigationBar): fix styles Signed-off-by: scffs <khidey@inbox.ru> * fix(SubnavigationBar): returned a comment Signed-off-by: scffs <khidey@inbox.ru> * Update packages/vkui/src/components/SubnavigationBar/SubnavigationBar.module.css Co-authored-by: Daniil Suvorov <severecloud@gmail.com> * Update packages/vkui/src/components/SubnavigationBar/SubnavigationBar.module.css Co-authored-by: Daniil Suvorov <severecloud@gmail.com> * combine into one padding * fix invalid prop value unset ломает верстку Co-authored-by: Daniil Suvorov <severecloud@gmail.com> * feat(subnavigation-bar-a11y): del global Signed-off-by: scffs <khidey@inbox.ru> * feat(subnavigation-bar-a11y): del `className` and add `TODO` Signed-off-by: scffs <khidey@inbox.ru> * Revert "feat(subnavigation-bar-a11y): del global" This reverts commit 4a5a80a. * feat(subnavigation-bar-a11y): move TODO Signed-off-by: scffs <khidey@inbox.ru> --------- Signed-off-by: scffs <khidey@inbox.ru> Co-authored-by: Daniil Suvorov <severecloud@gmail.com>

* feat(update-doc): add htmlFor / bottomId + aria-describedby (#5459) Signed-off-by: scffs <khidey@inbox.ru> Co-authored-by: Inomdzhon Mirdzhamolov <inomjon92@gmail.com> Co-authored-by: GitHub Action <actions@github.com> * fix(SubnavigationBar): combining buttons into a list [a11y] (#5225) * fix(Popover): fix incorrect words ending * Revert "doc(Popover): incorrect declension of two words" This reverts commit 8494645. * fix(SubnavigationBar): the `SubnavigationButton` components are combined into a list Signed-off-by: scffs <khidey@inbox.ru> * fix(SubnavigationBar): getting rid of the extra div Signed-off-by: scffs <khidey@inbox.ru> * Revert "Revert "doc(Popover): incorrect declension of two words"" This reverts commit 9ff5698. * fix(SubnavigationBar): using `React.Children.toArray` instead of `Component="li"` props in `Tappable` Signed-off-by: scffs <khidey@inbox.ru> * fix(SubnavigationBar): added `key` Signed-off-by: scffs <khidey@inbox.ru> * fix(SubnavigationBar): fix styles Signed-off-by: scffs <khidey@inbox.ru> * fix(SubnavigationBar): returned a comment Signed-off-by: scffs <khidey@inbox.ru> * Update packages/vkui/src/components/SubnavigationBar/SubnavigationBar.module.css Co-authored-by: Daniil Suvorov <severecloud@gmail.com> * Update packages/vkui/src/components/SubnavigationBar/SubnavigationBar.module.css Co-authored-by: Daniil Suvorov <severecloud@gmail.com> * combine into one padding * fix invalid prop value unset ломает верстку Co-authored-by: Daniil Suvorov <severecloud@gmail.com> * feat(subnavigation-bar-a11y): del global Signed-off-by: scffs <khidey@inbox.ru> * feat(subnavigation-bar-a11y): del `className` and add `TODO` Signed-off-by: scffs <khidey@inbox.ru> * Revert "feat(subnavigation-bar-a11y): del global" This reverts commit 4a5a80a. * feat(subnavigation-bar-a11y): move TODO Signed-off-by: scffs <khidey@inbox.ru> --------- Signed-off-by: scffs <khidey@inbox.ru> Co-authored-by: Daniil Suvorov <severecloud@gmail.com> --------- Signed-off-by: scffs <khidey@inbox.ru> Co-authored-by: Inomdzhon Mirdzhamolov <inomjon92@gmail.com> Co-authored-by: GitHub Action <actions@github.com>

scffs and others added 6 commits June 8, 2023 18:55

fix(Popover): fix incorrect words ending

20cb75a

Merge branch 'VKCOM:master' into master

42f38b6

Revert "doc(Popover): incorrect declension of two words"

9ff5698

This reverts commit 8494645.

fix(SubnavigationBar): the SubnavigationButton components are combi…

ad00bd4

…ned into a list Signed-off-by: scffs <khidey@inbox.ru>

fix(SubnavigationBar): getting rid of the extra div

e73fa8f

Signed-off-by: scffs <khidey@inbox.ru>

Revert "Revert "doc(Popover): incorrect declension of two words""

216020a

This reverts commit 9ff5698.

scffs requested a review from a team as a code owner June 11, 2023 10:06

scffs commented Jun 11, 2023

View reviewed changes

packages/vkui/src/components/SubnavigationBar/SubnavigationBar.module.css Outdated Show resolved Hide resolved

scffs added 4 commits June 11, 2023 20:41

fix(SubnavigationBar): using React.Children.toArray instead of `Com…

d74c4ab

…ponent="li"` props in `Tappable` Signed-off-by: scffs <khidey@inbox.ru>

fix(SubnavigationBar): added key

78947c8

Signed-off-by: scffs <khidey@inbox.ru>

fix(SubnavigationBar): fix styles

658b676

Signed-off-by: scffs <khidey@inbox.ru>

fix(SubnavigationBar): returned a comment

ed25a32

Signed-off-by: scffs <khidey@inbox.ru>

scffs changed the title ~~fix(SubnavigationBar): combining buttons into a list [a11y ]~~ fix(SubnavigationBar): combining buttons into a list [a11y] Jun 15, 2023

SevereCloud reviewed Jun 22, 2023

View reviewed changes

packages/vkui/src/components/SubnavigationBar/SubnavigationBar.module.css Outdated Show resolved Hide resolved

Update packages/vkui/src/components/SubnavigationBar/SubnavigationBar…

8137555

….module.css Co-authored-by: Daniil Suvorov <severecloud@gmail.com>

SevereCloud requested a review from eugpoloz June 22, 2023 07:54

SevereCloud reviewed Jun 22, 2023

View reviewed changes

packages/vkui/src/components/SubnavigationBar/SubnavigationBar.module.css Outdated Show resolved Hide resolved

scffs and others added 2 commits June 22, 2023 15:31

Update packages/vkui/src/components/SubnavigationBar/SubnavigationBar…

3857cff

….module.css Co-authored-by: Daniil Suvorov <severecloud@gmail.com>

combine into one padding

02b3b6e

SevereCloud reviewed Jun 22, 2023

View reviewed changes

packages/vkui/src/components/SubnavigationBar/SubnavigationBar.module.css Outdated Show resolved Hide resolved

fix invalid prop value

08cb6f1

unset ломает верстку Co-authored-by: Daniil Suvorov <severecloud@gmail.com>

SevereCloud previously approved these changes Jun 22, 2023

View reviewed changes

github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Jun 29, 2023

github-actions bot closed this Jul 7, 2023

SevereCloud reopened this Jul 10, 2023

SevereCloud removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Jul 10, 2023

inomdzhon reviewed Jul 12, 2023

View reviewed changes

packages/vkui/src/components/SubnavigationButton/SubnavigationButton.module.css Show resolved Hide resolved

scffs added 2 commits July 12, 2023 22:15

feat(subnavigation-bar-a11y): del global

4a5a80a

Signed-off-by: scffs <khidey@inbox.ru>

feat(subnavigation-bar-a11y): del className and add TODO

68b7a4b

Signed-off-by: scffs <khidey@inbox.ru>

scffs dismissed SevereCloud’s stale review via 68b7a4b July 12, 2023 15:16

inomdzhon reviewed Jul 13, 2023

View reviewed changes

packages/vkui/src/components/SubnavigationButton/SubnavigationButton.module.css Outdated Show resolved Hide resolved

packages/vkui/src/components/SubnavigationBar/SubnavigationBar.tsx Outdated Show resolved Hide resolved

scffs added 2 commits July 13, 2023 16:30

Revert "feat(subnavigation-bar-a11y): del global"

39aacd4

This reverts commit 4a5a80a.

feat(subnavigation-bar-a11y): move TODO

24882e8

Signed-off-by: scffs <khidey@inbox.ru>

inomdzhon approved these changes Jul 13, 2023

View reviewed changes

inomdzhon added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Jul 13, 2023

SevereCloud approved these changes Jul 17, 2023

View reviewed changes

SevereCloud merged commit ccfb8e4 into VKCOM:master Jul 17, 2023

SevereCloud mentioned this pull request Jul 17, 2023

patch: pr5225 pr5459 #5485

Merged

scffs deleted the subnavigation-bar-a11y branch July 17, 2023 15:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(SubnavigationBar): combining buttons into a list [a11y] #5225

fix(SubnavigationBar): combining buttons into a list [a11y] #5225

scffs commented Jun 11, 2023 •

edited

Loading

codesandbox-ci bot commented Jun 11, 2023 •

edited

Loading

codecov bot commented Jun 11, 2023 •

edited

Loading

github-actions bot commented Jun 11, 2023 •

edited

Loading

github-actions bot commented Jun 11, 2023 •

edited

Loading

github-actions bot commented Jun 11, 2023 •

edited

Loading

github-actions bot commented Jul 7, 2023

scffs commented Jul 13, 2023

inomdzhon left a comment

inomdzhon commented Jul 13, 2023

vkcom-publisher commented Jul 17, 2023

fix(SubnavigationBar): combining buttons into a list [a11y] #5225

fix(SubnavigationBar): combining buttons into a list [a11y] #5225

Conversation

scffs commented Jun 11, 2023 • edited Loading

codesandbox-ci bot commented Jun 11, 2023 • edited Loading

codecov bot commented Jun 11, 2023 • edited Loading

Codecov Report

github-actions bot commented Jun 11, 2023 • edited Loading

size-limit report 📦

github-actions bot commented Jun 11, 2023 • edited Loading

👀 Docs deployed

github-actions bot commented Jun 11, 2023 • edited Loading

e2e tests

github-actions bot commented Jul 7, 2023

scffs commented Jul 13, 2023

inomdzhon left a comment

Choose a reason for hiding this comment

inomdzhon commented Jul 13, 2023

vkcom-publisher commented Jul 17, 2023

⚠️ Patch (forked repo)

scffs commented Jun 11, 2023 •

edited

Loading

codesandbox-ci bot commented Jun 11, 2023 •

edited

Loading

codecov bot commented Jun 11, 2023 •

edited

Loading

github-actions bot commented Jun 11, 2023 •

edited

Loading

github-actions bot commented Jun 11, 2023 •

edited

Loading

github-actions bot commented Jun 11, 2023 •

edited

Loading