Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Math.ts): updated decimatedClamp implementation #5284

Merged
merged 4 commits into from
Jul 12, 2023
Merged

fix(Math.ts): updated decimatedClamp implementation #5284

merged 4 commits into from
Jul 12, 2023

Conversation

scffs
Copy link
Contributor

@scffs scffs commented Jun 17, 2023

Signed-off-by: scffs <khidey@inbox.ru>
@scffs scffs requested a review from a team as a code owner June 17, 2023 15:23
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 17, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ec1bef7:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2023

👀 Docs deployed

Commit ec1bef7

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2023

size-limit report 📦

Path Size
JS 310.14 KB (+0.02% 🔺)
JS (gzip) 90.67 KB (+0.05% 🔺)
JS (brotli) 75.38 KB (+0.08% 🔺)
JS import Div (tree shaking) 2.97 KB (0%)
CSS 271.88 KB (0%)
CSS (gzip) 35.48 KB (0%)
CSS (brotli) 28.13 KB (0%)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2023

e2e tests

Playwright Report

@SevereCloud SevereCloud added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Jun 19, 2023
@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Jun 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно.

@github-actions github-actions bot closed this Jul 3, 2023
@scffs
Copy link
Contributor Author

scffs commented Jul 7, 2023

а можно ревью пж

@BlackySoul BlackySoul reopened this Jul 7, 2023
@BlackySoul BlackySoul removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Jul 7, 2023
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

К сожалению, текущие изменения в PR ломают тесты, которые должны проходить без изменений (с одним исключением, см. п.3 в комментарии к коду #5284 (comment)).

Ниже ссылка на песочницу, которая запускает две версии rescale():

  1. То, что предложил в комментарии к коду fix(Math.ts): updated decimatedClamp implementation #5284 (comment)
  2. То, что сейчас в VKUI 5.5.5

Ссылка на песочницу

packages/vkui/src/helpers/math.ts Outdated Show resolved Hide resolved
scffs added 3 commits July 11, 2023 18:22
Signed-off-by: scffs <khidey@inbox.ru>
Signed-off-by: scffs <khidey@inbox.ru>
Signed-off-by: scffs <khidey@inbox.ru>
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10 ⚠️

Comparison is base (55cc0ce) 81.73% compared to head (ec1bef7) 81.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5284      +/-   ##
==========================================
- Coverage   81.73%   81.64%   -0.10%     
==========================================
  Files         283      284       +1     
  Lines        9485     9531      +46     
  Branches     3019     3043      +24     
==========================================
+ Hits         7753     7782      +29     
- Misses       1732     1749      +17     
Flag Coverage Δ
unittests 81.64% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/vkui/src/helpers/math.ts 88.00% <100.00%> (-12.00%) ⬇️

... and 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@inomdzhon inomdzhon merged commit 5631f38 into VKCOM:master Jul 12, 2023
@vkcom-publisher
Copy link
Contributor

⚠️ Patch (forked repo)

Необходимо вручную перенести исправление в стабильную ветку.

Дальнейшие действия выполняют контрибьютеры из группы @VKCOM/vkui-core

Чтобы исправление попало в стабильную ветку, выполните следующие действия:

  1. Создайте новую ветку от стабильной и примените исправления используя cherry-pick
git stash # опционально
git fetch origin 5.6-stable
git checkout -b patch/pr5284 origin/5.6-stable

git cherry-pick --no-commit dab7f3819bbbaa13d2b10527a4baf79b2f63e20b
git checkout HEAD **/__image_snapshots__/*.png
git commit --no-verify --no-edit

git cherry-pick --no-commit 30b88f950e8455aae10241f9297a84191c2ef785
git checkout HEAD **/__image_snapshots__/*.png
git commit --no-verify --no-edit

git cherry-pick --no-commit 76829ce53dfc74d6bbea3159de34642aef2cb1cc
git checkout HEAD **/__image_snapshots__/*.png
git commit --no-verify --no-edit

git cherry-pick --no-commit ec1bef7bc19d831a6e66802aa3cbddbfa204904d
git checkout HEAD **/__image_snapshots__/*.png
git commit --no-verify --no-edit
  1. Исправьте конфликты, следуя инструкциям из терминала
  2. Отправьте ветку на GitHub и создайте новый PR с последней стабильной веткой (метка patch не нужна)
git push --set-upstream origin patch/pr5284
gh pr create --base 5.6-stable --title "patch: pr5284" --body "- patch #5284"

inomdzhon added a commit that referenced this pull request Jul 12, 2023
* fix(FormItem): add `aria-labelledby` support for `bottom` + `Input` (#5422)

* fix(Math.ts): updated `decimatedClamp` implementation (#5284)

---------

Co-authored-by: Semyon Okulov <67464545+scffs@users.noreply.github.com>
@scffs scffs deleted the fixmath branch July 13, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Slider не доходит до конца
5 participants