-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Math.ts): updated decimatedClamp
implementation
#5284
Conversation
scffs
commented
Jun 17, 2023
•
edited by inomdzhon
Loading
edited by inomdzhon
- closes [Bug]: Slider не доходит до конца #5283
Signed-off-by: scffs <khidey@inbox.ru>
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ec1bef7:
|
👀 Docs deployedCommit ec1bef7 |
size-limit report 📦
|
e2e tests |
PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно. |
а можно ревью пж |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
К сожалению, текущие изменения в PR ломают тесты, которые должны проходить без изменений (с одним исключением, см. п.3 в комментарии к коду #5284 (comment)).
Ниже ссылка на песочницу, которая запускает две версии rescale()
:
- То, что предложил в комментарии к коду fix(Math.ts): updated
decimatedClamp
implementation #5284 (comment) - То, что сейчас в VKUI 5.5.5
Signed-off-by: scffs <khidey@inbox.ru>
Signed-off-by: scffs <khidey@inbox.ru>
Signed-off-by: scffs <khidey@inbox.ru>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5284 +/- ##
==========================================
- Coverage 81.73% 81.64% -0.10%
==========================================
Files 283 284 +1
Lines 9485 9531 +46
Branches 3019 3043 +24
==========================================
+ Hits 7753 7782 +29
- Misses 1732 1749 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|