Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ActionSheet): add default iOS close item #5502

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

BlackySoul
Copy link
Contributor

Делаем проп iosCloseItem необязательным и по дефолту проставляем ActionSheetDefaultIosCloseItem, чтобы не нужно было прокидывать вручную.

@BlackySoul BlackySoul requested a review from a team as a code owner July 20, 2023 13:00
@BlackySoul BlackySoul self-assigned this Jul 20, 2023
@BlackySoul BlackySoul added this to the v5.7.0 milestone Jul 20, 2023
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit baf16c6:

Sandbox Source
VKUI TypeScript Configuration

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.02 ⚠️

Comparison is base (e82e78d) 81.72% compared to head (baf16c6) 81.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5502      +/-   ##
==========================================
- Coverage   81.72%   81.71%   -0.02%     
==========================================
  Files         286      286              
  Lines        9582     9585       +3     
  Branches     3057     3059       +2     
==========================================
+ Hits         7831     7832       +1     
- Misses       1751     1753       +2     
Flag Coverage Δ
unittests 81.71% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/vkui/src/components/ActionSheet/ActionSheet.tsx 91.42% <50.00%> (-2.61%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

👀 Docs deployed

Commit baf16c6

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 311.93 KB (+0.02% 🔺)
JS (gzip) 91.17 KB (+0.02% 🔺)
JS (brotli) 75.8 KB (+0.1% 🔺)
JS import Div (tree shaking) 2.97 KB (0%)
CSS 274.1 KB (0%)
CSS (gzip) 35.8 KB (0%)
CSS (brotli) 28.33 KB (0%)

@github-actions
Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@BlackySoul BlackySoul merged commit 1b4f558 into master Jul 20, 2023
@BlackySoul BlackySoul deleted the blackysoul/add_defualt_ios_close_prop branch July 20, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants