Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Card): Add outline-tint mode #5533

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

BlackySoul
Copy link
Contributor

@BlackySoul BlackySoul commented Jul 27, 2023

@BlackySoul BlackySoul requested a review from a team as a code owner July 27, 2023 17:49
@BlackySoul BlackySoul marked this pull request as draft July 27, 2023 17:49
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 27, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a4a992c:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

👀 Docs deployed

Commit a4a992c

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

size-limit report 📦

Path Size
JS 312.41 KB (+0.02% 🔺)
JS (gzip) 91.34 KB (+0.03% 🔺)
JS (brotli) 75.85 KB (-0.08% 🔽)
JS import Div (tree shaking) 2.97 KB (0%)
CSS 272.31 KB (-0.01% 🔽)
CSS (gzip) 35.62 KB (+0.02% 🔺)
CSS (brotli) 28.23 KB (+0.06% 🔺)

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07% 🎉

Comparison is base (29c5b59) 81.69% compared to head (a4a992c) 81.76%.
Report is 23 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5533      +/-   ##
==========================================
+ Coverage   81.69%   81.76%   +0.07%     
==========================================
  Files         286      289       +3     
  Lines        9575     9623      +48     
  Branches     3054     3063       +9     
==========================================
+ Hits         7822     7868      +46     
- Misses       1753     1755       +2     
Flag Coverage Δ
unittests 81.76% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/vkui/src/components/Card/Card.tsx 100.00% <100.00%> (ø)

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

e2e tests

Playwright Report

@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Aug 4, 2023
@BlackySoul BlackySoul removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Aug 4, 2023
@BlackySoul BlackySoul marked this pull request as ready for review August 7, 2023 04:16
@BlackySoul BlackySoul requested review from mendrew and eugpoloz August 7, 2023 11:45
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

@BlackySoul BlackySoul merged commit 56617e6 into master Aug 10, 2023
@BlackySoul BlackySoul deleted the feat/5501/Card_add_tint_outline_mode branch August 10, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Добавить новый режим для компонента Card
4 participants