fix(ChipsSelect): Use showSelected prop #5684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It used to be not used by us for some reason. While it should prevent filtering out selected options from the dropdown list.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2e9f678:
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5684 +/- ##
=======================================
Coverage 81.90% 81.91%
=======================================
Files 296 296
Lines 9765 9768 +3
Branches 3094 3096 +2
=======================================
+ Hits 7998 8001 +3
Misses 1767 1767
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
👀 Docs deployedCommit 2e9f678 |
e2e tests |
SevereCloud
reviewed
Aug 23, 2023
SevereCloud
approved these changes
Aug 23, 2023
mendrew
added
the
patch
mendrew
deleted the
mendrew/fix/5677/ChipSelect/show-selected-prop-is-not-working
branch
vkcom-publisher
pushed a commit
that referenced
this pull request
Aug 24, 2023
fixes: #5677 По какой-то причине мы вообще не использовали этот проп. Изменения: - при включенном пропе `showSelected` выбранные опции не отфильтровываются. - поправил логику закрытия по клику мимо селекта. Оказалось, оттого, что дропдаунт рендерится через портал, click outside логика срабатывает при клике по опции и селект закрывается. Раньше это не было заметно, потому без правильно работающего showSelected пропа выбранные опции всегда удалялись из dropdown и событие клика по опции никак не обрабатывалось и не всплывало до body. А по какой опции был сделан клик мы определяли по `onMouseDown`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #5677
Описание
По какой-то причине мы вообще не использовали этот проп.
Изменения
showSelectedвыбранные опции не отфильтровываются.onMouseDown.