fix(TextTooltip/Popper): Hide Popper when reference element dissapears #5690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4d08d90:
|
👀 Docs deployedCommit c44c899 |
size-limit report 📦
|
e2e tests |
mendrew
force-pushed
the
mendrew/fix/5675/TextTooltip/dissapear-when-anchor-dissapear
branch
from
c44c899 to
3de000b
Compare
👀 Docs deployed
Commit 4d08d90 |
inomdzhon
reviewed
Aug 25, 2023
Use hide middleware and apply visually: "hidden" when reference element hides from the dom or has no size
mendrew
force-pushed
the
mendrew/fix/5675/TextTooltip/dissapear-when-anchor-dissapear
branch
from
3de000b to
5a040fb
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5690 +/- ##
==========================================
+ Coverage 81.92% 81.96% +0.03%
==========================================
Files 296 296
Lines 9776 9785 +9
Branches 3099 3104 +5
==========================================
+ Hits 8009 8020 +11
+ Misses 1767 1765 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
As this middleware is no longer used by default
inomdzhon
reviewed
Aug 29, 2023
SevereCloud
approved these changes
Aug 31, 2023
mendrew
deleted the
mendrew/fix/5675/TextTooltip/dissapear-when-anchor-dissapear
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #5675
Описание
Используем hide middleware. Позволяет определить что стоит спрятать
Popperесли элемент относительно которого позиционирован Popper пропал.Popper прячем c помощью
visually: hidden.Специально, чтобы тултип не прыгал, если элемент, относительно которого спозиционирован тултип, внезапно исчез.