Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech: turn on declaration map for vkui package #5748

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

mendrew
Copy link
Contributor

@mendrew mendrew commented Sep 5, 2023

resolves: #5593

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 5, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f3a942c:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

size-limit report 📦

Path Size
JS 346.1 KB (0%)
JS (gzip) 103.22 KB (0%)
JS (brotli) 84.33 KB (0%)
JS import Div (tree shaking) 3.04 KB (0%)
CSS 278.5 KB (0%)
CSS (gzip) 36.33 KB (0%)
CSS (brotli) 28.74 KB (0%)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

👀 Docs deployed

Commit f3a942c

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d2833ff) 81.99% compared to head (f3a942c) 81.99%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5748   +/-   ##
=======================================
  Coverage   81.99%   81.99%           
=======================================
  Files         298      298           
  Lines        9839     9839           
  Branches     3115     3115           
=======================================
  Hits         8067     8067           
  Misses       1772     1772           
Flag Coverage Δ
unittests 81.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SevereCloud SevereCloud added the v5 Автоматизация: PR продублируется в ветку v5 label Sep 6, 2023
@mendrew mendrew force-pushed the mendrew/tech/5594/update-yarn-to-v3 branch 2 times, most recently from 8e56ce8 to a018abd Compare September 7, 2023 15:10
Base automatically changed from mendrew/tech/5594/update-yarn-to-v3 to master September 8, 2023 16:28
By excluding tests storybook etc. related files
@mendrew mendrew force-pushed the mendrew/tech/5593/turn-on-declaration-map-for-vkui branch from 57ecd12 to a41a650 Compare September 11, 2023 08:16
@mendrew mendrew marked this pull request as ready for review September 11, 2023 09:59
@mendrew mendrew requested a review from a team as a code owner September 11, 2023 09:59
@mendrew mendrew merged commit a3da40d into master Sep 11, 2023
44 checks passed
@mendrew mendrew deleted the mendrew/tech/5593/turn-on-declaration-map-for-vkui branch September 11, 2023 10:18
vkcom-publisher pushed a commit that referenced this pull request Sep 11, 2023
Turn on declarationMap and include source files to the package

By excluding tests storybook etc. related files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v5 Автоматизация: PR продублируется в ветку v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: включить declarationMap в TS для пакета @vkontakte/vkui
3 participants