feat: color_separator_primary dpi #5791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
inomdzhon
previously approved these changes
Sep 12, 2023
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3c8edaf:
|
e2e tests |
👀 Docs deployed
Commit 3c8edaf |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #5791 +/- ##
=======================================
Coverage 81.99% 81.99%
=======================================
Files 298 298
Lines 9839 9839
Branches 3115 3115
=======================================
Hits 8067 8067
Misses 1772 1772
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Исправляем color_separator_primary в зависимости от dpi В будущем требуется переименовать токены ```diff - --vkui_internal--color_separator_primary: var(--vkui--color_separator_primary); + --vkui--color_separator_primary: var(--vkui--color_separator_primary1x); ```
SevereCloud
force-pushed
the
SevereCloud/feat/color_separator_primary-dpi
branch
from
0d53140 to
3c8edaf
Compare
BlackySoul
approved these changes
Sep 12, 2023
inomdzhon
approved these changes
Sep 12, 2023
SevereCloud
deleted the
SevereCloud/feat/color_separator_primary-dpi
branch
SevereCloud
added a commit
that referenced
this pull request
Sep 12, 2023
Исправляем color_separator_primary в зависимости от dpi В будущем требуется переименовать токены ```diff - --vkui_internal--color_separator_primary: var(--vkui--color_separator_primary); + --vkui--color_separator_primary: var(--vkui--color_separator_primary1x); ```
Merged
SevereCloud
added a commit
that referenced
this pull request
Sep 13, 2023
Исправляем color_separator_primary в зависимости от dpi В будущем требуется переименовать токены ```diff - --vkui_internal--color_separator_primary: var(--vkui--color_separator_primary); + --vkui--color_separator_primary: var(--vkui--color_separator_primary1x); ```
|
✅ v5.9.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] Unit-тестывизуальное исправление[ ] e2e-тестынет инфры под разный dpi[ ] Дизайн-ревьювизуальное исправлениеОписание
Делаем color_separator_primary в зависимости от dpi