Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Banner): padding in #5824

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix(Banner): padding in #5824

merged 1 commit into from
Sep 19, 2023

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Sep 18, 2023


  • [ ] Unit-тесты визуальное исправление
  • e2e-тесты
  • [ ] Дизайн-ревью визуальное исправление

Изменения

Исправил отступ внутри баннера

@SevereCloud SevereCloud requested a review from a team as a code owner September 18, 2023 12:14
@SevereCloud SevereCloud added patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча v5 Автоматизация: PR продублируется в ветку v5 labels Sep 18, 2023
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 18, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f87bc97:

Sandbox Source
VKUI TypeScript Configuration
vkui-banner-paddings-bug Issue #5788

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023

size-limit report 📦

Path Size
JS 316.23 KB (-0.01% 🔽)
JS (gzip) 96.48 KB (-0.02% 🔽)
JS (brotli) 79.95 KB (+0.05% 🔺)
JS import Div (tree shaking) 2.95 KB (0%)
CSS 275.7 KB (-0.03% 🔽)
CSS (gzip) 35.99 KB (-0.05% 🔽)
CSS (brotli) 28.53 KB (+0.08% 🔺)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023

👀 Docs deployed

Commit f87bc97

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (95e80a2) 80.85% compared to head (f87bc97) 80.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5824   +/-   ##
=======================================
  Coverage   80.85%   80.85%           
=======================================
  Files         299      299           
  Lines        9156     9156           
  Branches     3118     3119    +1     
=======================================
  Hits         7403     7403           
  Misses       1753     1753           
Flag Coverage Δ
unittests 80.85% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/vkui/src/components/Banner/Banner.tsx 80.43% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SevereCloud SevereCloud merged commit 2168789 into master Sep 19, 2023
23 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/issue5788 branch September 19, 2023 09:19
vkcom-publisher pushed a commit that referenced this pull request Sep 19, 2023
vkcom-publisher pushed a commit that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча v5 Автоматизация: PR продублируется в ветку v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Banner не верные внутренние отступы
4 participants