Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ActionSheet): add mode #5829

Merged
merged 1 commit into from
Sep 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -91,15 +91,15 @@
* Desktop version
*/

.ActionSheet--desktop {
.ActionSheet--menu {
width: auto;
height: auto;
animation: none;
padding: 0;
max-width: 100%;
}

.ActionSheet--desktop.ActionSheet--ios .ActionSheet__content-wrapper {
.ActionSheet--menu.ActionSheet--ios .ActionSheet__content-wrapper {
border-radius: 14px;
padding: 0;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,18 @@ describe('ActionSheet', () => {
<ActionSheet toggleRef={toggle} onClose={jest.fn()} {...props} />
</AdaptivityProvider>
);
const ActionSheetMenu = (props: Partial<ActionSheetProps>) => (
<ActionSheet mode="menu" toggleRef={toggle} onClose={jest.fn()} {...props} />
);
const ActionSheetSheet = (props: Partial<ActionSheetProps>) => (
<ActionSheet mode="sheet" toggleRef={toggle} onClose={jest.fn()} {...props} />
);

describe.each([
['desktop', ActionSheetDesktop],
['mobile', ActionSheetMobile],
['menu', ActionSheetMenu],
['sheet', ActionSheetSheet],
])('%s', (_name, ActionSheet) => {
baselineComponent((props) => <ActionSheet {...props} />, {
// TODO [a11y]: "Exceeded timeout of 5000 ms for a test.
Expand Down
30 changes: 17 additions & 13 deletions packages/vkui/src/components/ActionSheet/ActionSheet.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ import { PopoutWrapper } from '../PopoutWrapper/PopoutWrapper';
import { Footnote } from '../Typography/Footnote/Footnote';
import { ActionSheetContext, ItemClickHandler } from './ActionSheetContext';
import { ActionSheetDefaultIosCloseItem } from './ActionSheetDefaultIosCloseItem';
import { ActionSheetDropdown } from './ActionSheetDropdown';
import { ActionSheetDropdownDesktop } from './ActionSheetDropdownDesktop';
import { ActionSheetDropdownMenu } from './ActionSheetDropdownMenu';
import { ActionSheetDropdownSheet } from './ActionSheetDropdownSheet';
import { SharedDropdownProps } from './types';
import styles from './ActionSheet.module.css';

Expand All @@ -38,6 +38,7 @@ export interface ActionSheetProps
* Только мобильный iOS.
*/
iosCloseItem?: React.ReactNode;
mode?: 'sheet' | 'menu';
}

/**
Expand All @@ -53,6 +54,7 @@ export const ActionSheet = ({
popupDirection,
popupOffsetDistance,
placement,
mode: modeProp,
...restProps
}: ActionSheetProps) => {
const platform = usePlatform();
Expand All @@ -67,12 +69,13 @@ export const ActionSheet = ({
};

const { isDesktop } = useAdaptivityWithJSMediaQueries();
const mode = modeProp ?? (isDesktop ? 'menu' : 'sheet');

useScrollLock(!isDesktop);
useScrollLock(mode === 'sheet');

let timeout = platform === Platform.IOS ? 300 : 200;

if (isDesktop) {
if (mode === 'menu') {
timeout = 0;
}

Expand All @@ -99,9 +102,9 @@ export const ActionSheet = ({
},
[],
);
const contextValue = useObjectMemo({ onItemClick, isDesktop });
const contextValue = useObjectMemo({ onItemClick, mode });

const DropdownComponent = isDesktop ? ActionSheetDropdownDesktop : ActionSheetDropdown;
const DropdownComponent = mode === 'menu' ? ActionSheetDropdownMenu : ActionSheetDropdownSheet;

if (process.env.NODE_ENV === 'development' && popupDirection) {
// TODO [>=6]: popupDirection
Expand All @@ -110,9 +113,10 @@ export const ActionSheet = ({

popupDirection = popupDirection !== undefined ? popupDirection : 'bottom';

const dropdownProps = isDesktop
? Object.assign(restProps, { popupOffsetDistance, popupDirection, placement })
: restProps;
const dropdownProps =
mode === 'menu'
? Object.assign(restProps, { popupOffsetDistance, popupDirection, placement })
: restProps;

const actionSheet = (
<ActionSheetContext.Provider value={contextValue}>
Expand All @@ -121,8 +125,8 @@ export const ActionSheet = ({
timeout={timeout}
{...dropdownProps}
onClose={onClose}
className={isDesktop ? className : undefined}
style={isDesktop ? style : undefined}
className={mode === 'menu' ? className : undefined}
style={mode === 'menu' ? style : undefined}
>
<div className={styles['ActionSheet__content-wrapper']}>
{(header || text) && (
Expand All @@ -137,7 +141,7 @@ export const ActionSheet = ({
)}
{children}
</div>
{platform === Platform.IOS && !isDesktop && (
{platform === Platform.IOS && mode === 'sheet' && (
<div className={styles['ActionSheet__close-item-wrapper--ios']}>
{iosCloseItem ?? <ActionSheetDefaultIosCloseItem />}
</div>
Expand All @@ -146,7 +150,7 @@ export const ActionSheet = ({
</ActionSheetContext.Provider>
);

if (isDesktop) {
if (mode === 'menu') {
return actionSheet;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export type ItemClickHandler<T extends Element = Element> = (options: {

export type ActionSheetContextType<T extends Element = Element> = {
onItemClick?: ItemClickHandler<T>;
isDesktop?: boolean;
mode?: 'sheet' | 'menu';
};

export const ActionSheetContext = React.createContext<ActionSheetContextType<any>>({});
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ function getEl(ref: SharedDropdownProps['toggleRef']): Element | null | undefine
return ref && 'current' in ref ? ref.current : ref;
}

export const ActionSheetDropdownDesktop = ({
export const ActionSheetDropdownMenu = ({
children,
toggleRef,
closing,
Expand Down Expand Up @@ -83,7 +83,7 @@ export const ActionSheetDropdownDesktop = ({
className={classNames(
styles['ActionSheet'],
platform === Platform.IOS && styles['ActionSheet--ios'],
styles['ActionSheet--desktop'],
styles['ActionSheet--menu'],
sizeY === SizeType.COMPACT && styles['ActionSheet--sizeY-compact'],
className,
)}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export type ActionSheetDropdownProps = Omit<
'popupDirection' | 'popupOffsetDistance' | 'placement'
>;

export const ActionSheetDropdown = ({
export const ActionSheetDropdownSheet = ({
children,
closing,
// these 2 props are only omitted - ActionSheetDesktop compat
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
margin-right: 16px;
}

.ActionSheetItem--desktop .ActionSheetItem__before {
.ActionSheetItem--menu .ActionSheetItem__before {
margin-right: 12px;
}

Expand Down Expand Up @@ -186,7 +186,7 @@
* Desktop
*/

.ActionSheetItem--desktop {
.ActionSheetItem--menu {
width: auto;
cursor: pointer;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ const ActionSheetItem = ({
...restProps
}: ActionSheetItemProps) => {
const platform = usePlatform();
const { onItemClick = () => noop, isDesktop } =
const { onItemClick = () => noop, mode: actionSheetMode } =
React.useContext<ActionSheetContextType<HTMLElement>>(ActionSheetContext);
const { sizeY } = useAdaptivityWithJSMediaQueries();

Expand Down Expand Up @@ -109,7 +109,7 @@ const ActionSheetItem = ({
mode === 'destructive' && styles['ActionSheetItem--mode-destructive'],
sizeY === SizeType.COMPACT && styles['ActionSheetItem--sizeY-compact'],
isRich && styles['ActionSheetItem--rich'],
isDesktop && styles['ActionSheetItem--desktop'],
actionSheetMode === 'menu' && styles['ActionSheetItem--menu'],
selectable && styles['ActionSheetItem--selectable'],
className,
)}
Expand Down
Loading