Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ScrollArrow): add up & down #5839

Merged
merged 1 commit into from
Sep 21, 2023
Merged

feat(ScrollArrow): add up & down #5839

merged 1 commit into from
Sep 21, 2023

Conversation

SevereCloud
Copy link
Contributor


  • [ ] Unit-тесты
  • e2e-тесты
  • [ ] Дизайн-ревью

Описание

Добавляем up и down направления стрелки

Изменения

Теперь в качестве иконки используется только стрелка вправо и в css она поворачивается в нужное направление

@SevereCloud SevereCloud requested a review from a team as a code owner September 20, 2023 11:47
@SevereCloud SevereCloud added the v5 Автоматизация: PR продублируется в ветку v5 label Sep 20, 2023
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bd1d66e:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 317.11 KB (-0.09% 🔽)
JS (gzip) 96.79 KB (-0.02% 🔽)
JS (brotli) 80.12 KB (-0.01% 🔽)
JS import Div (tree shaking) 2.95 KB (0%)
CSS 276.35 KB (+0.24% 🔺)
CSS (gzip) 36.07 KB (+0.24% 🔺)
CSS (brotli) 28.59 KB (+0.2% 🔺)

@github-actions
Copy link
Contributor

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

👀 Docs deployed

Commit bd1d66e

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 80.00% and no project coverage change.

Comparison is base (9525ded) 81.13% compared to head (bd1d66e) 81.13%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5839   +/-   ##
=======================================
  Coverage   81.13%   81.13%           
=======================================
  Files         300      300           
  Lines        9193     9193           
  Branches     3125     3123    -2     
=======================================
  Hits         7459     7459           
  Misses       1734     1734           
Flag Coverage Δ
unittests 81.13% <80.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...es/vkui/src/components/ScrollArrow/ScrollArrow.tsx 93.75% <80.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏👏👏 Классно придумал!

@SevereCloud SevereCloud merged commit e0076d5 into master Sep 21, 2023
24 of 25 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/issue5838 branch September 21, 2023 09:49
vkcom-publisher pushed a commit that referenced this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v5 Автоматизация: PR продублируется в ветку v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][ScrollArrow]: top и bottom direction
3 participants