Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Button): Specify correct font-family for the Button in different modes #5885

Merged
merged 2 commits into from
Sep 28, 2023
Merged

fix(Button): Specify correct font-family for the Button in different modes #5885

merged 2 commits into from
Sep 28, 2023

Conversation

mendrew
Copy link
Contributor

@mendrew mendrew commented Sep 28, 2023 •
edited
Loading

Описание

Поправили font-family в компоненте Button в зависимости от режима и платформы, согласно дизайн-системе,

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023 •
edited
Loading

size-limit report 📦

Path Size
JS 317.1 KB (0%)
JS (gzip) 96.74 KB (0%)
JS (brotli) 80.08 KB (0%)
JS import Div (tree shaking) 2.71 KB (0%)
CSS 278.1 KB (+0.41% 🔺)
CSS (gzip) 36.09 KB (-0.03% 🔽)
CSS (brotli) 28.66 KB (+0.14% 🔺)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 28, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8813add:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023 •
edited
Loading

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023 •
edited
Loading

👀 Docs deployed

Commit 8813add

@codecov
Copy link

codecov bot commented Sep 28, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2815c3b) 81.19% compared to head (6920e3e) 81.19%.

❗ Current head 6920e3e differs from pull request most recent head 8813add. Consider uploading reports for the commit 8813add to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5885   +/-   ##
=======================================
  Coverage   81.19%   81.19%           
=======================================
  Files         299      299           
  Lines        9189     9189           
  Branches     3120     3120           
=======================================
  Hits         7461     7461           
  Misses       1728     1728
Flag Coverage Δ
unittests 81.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mendrew mendrew marked this pull request as ready for review September 28, 2023 10:10
@mendrew mendrew requested a review from a team as a code owner September 28, 2023 10:10
@mendrew mendrew added the v5 Автоматизация: PR продублируется в ветку v5 label Sep 28, 2023
@mendrew mendrew merged commit 95e89d6 into master Sep 28, 2023
21 checks passed
@mendrew mendrew deleted the mendrew/fix/Button/font-family-in-different-modes branch September 28, 2023 16:29
vkcom-publisher pushed a commit that referenced this pull request Sep 28, 2023
@mendrew @actions-user
fix(Button): Specify correct font-family for the Button in different …
a291538 
…modes (#5885)

* Specify correct font-family for the Button in different modes
* Remove vkui--font_family_base usage
@stvor
Copy link

stvor commented Oct 5, 2023

Подскажите, этот фикс уже вошел в какую-то версию VKUI?

@BlackySoul
Copy link
Contributor

Подскажите, этот фикс уже вошел в какую-то версию VKUI?

Привет, можно воспрользоваться последней версией, там будет фикс (v5.9.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SevereCloud SevereCloud SevereCloud approved these changes

@BlackySoul BlackySoul BlackySoul approved these changes

Assignees
No one assigned
Labels
v5 Автоматизация: PR продублируется в ветку v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: неправильный токен шрифта в компоненте Button
4 participants
@mendrew @stvor @BlackySoul @SevereCloud