Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Panel): background color layout=card #5888

Merged

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Sep 28, 2023

  • [ ] Unit-тесты визуал
  • [ ] e2e-тест сложно отловить
  • [ ] Дизайн-ревью

Описание

Не учел переходы между панелями при layout=card

Изменения

При layout=card у Panel будет фон

@SevereCloud SevereCloud requested a review from a team as a code owner September 28, 2023 15:19
@SevereCloud SevereCloud added the v5 Автоматизация: PR продублируется в ветку v5 label Sep 28, 2023
@SevereCloud SevereCloud added this to the v5.9.0 milestone Sep 28, 2023
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d6d259f:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 317.1 KB (+0.01% 🔺)
JS (gzip) 96.74 KB (0%)
JS (brotli) 80.04 KB (-0.06% 🔽)
JS import Div (tree shaking) 2.71 KB (0%)
CSS 277.03 KB (+0.02% 🔺)
CSS (gzip) 36.11 KB (+0.02% 🔺)
CSS (brotli) 28.66 KB (+0.15% 🔺)

@github-actions
Copy link
Contributor

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

👀 Docs deployed

Commit d6d259f

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2815c3b) 81.19% compared to head (d6d259f) 81.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5888   +/-   ##
=======================================
  Coverage   81.19%   81.19%           
=======================================
  Files         299      299           
  Lines        9189     9189           
  Branches     3120     3120           
=======================================
  Hits         7461     7461           
  Misses       1728     1728           
Flag Coverage Δ
unittests 81.19% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/vkui/src/components/Panel/Panel.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@SevereCloud SevereCloud merged commit 42500e4 into master Sep 29, 2023
25 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/fix/Panel/background-color-layout=card branch September 29, 2023 11:55
@vkcom-publisher
Copy link
Contributor

v5.9.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v5 Автоматизация: PR продублируется в ветку v5
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants