fix(CustomScrollView): use default scrollbar if hasPointer=false #6437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
patch
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 93da177:
|
e2e tests |
👀 Docs deployed
Commit 93da177 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #6437 +/- ##
==========================================
+ Coverage 81.36% 81.98% +0.62%
==========================================
Files 327 327
Lines 10141 10146 +5
Branches 3413 3416 +3
==========================================
+ Hits 8251 8318 +67
+ Misses 1890 1828 -62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
inomdzhon
previously approved these changes
Jan 23, 2024
packages/vkui/src/components/CustomScrollView/CustomScrollView.tsx
Outdated
Show resolved
Hide resolved
….tsx Co-authored-by: Inomdzhon Mirdzhamolov <i.mirdzhamolov@vk.team>
inomdzhon
approved these changes
Jan 23, 2024
vkcom-publisher
pushed a commit
that referenced
this pull request
Jan 24, 2024
* fix(CustomScrollView): use default scrollbar if hasPointer=false - fixed #4756 --------- Co-authored-by: Inomdzhon Mirdzhamolov <i.mirdzhamolov@vk.team>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit-тестыe2e-тестыДизайн-ревьюДокументация фичиОписание
На смартфонах не требуется скроллбар
Изменения
Если главное устройство ввода не мышь, отключаем кастомый скроллбар