Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SimpleCell): disable indicator's shrinking #6477

Merged

Conversation

inomdzhon
Copy link
Contributor


  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи

Описание

Приоритезируем размер indicator за счёт flex-shirk: 0.

@inomdzhon inomdzhon requested a review from a team as a code owner January 26, 2024 15:18
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Jan 26, 2024
Copy link
Contributor

size-limit report 📦

Path Size
JS 348.93 KB (0%)
JS (gzip) 106.68 KB (0%)
JS (brotli) 88.19 KB (0%)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 257.98 KB (+0.01% 🔺)
CSS (gzip) 33.81 KB (+0.01% 🔺)
CSS (brotli) 27.47 KB (-0.15% 🔽)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ebdb32e:

Sandbox Source
VKUI TypeScript Configuration
shy-waterfall-8trwf8 Issue #3521

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit ebdb32e

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (447dc97) 82.02% compared to head (ebdb32e) 82.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6477   +/-   ##
=======================================
  Coverage   82.02%   82.02%           
=======================================
  Files         328      328           
  Lines       10158    10158           
  Branches     3420     3420           
=======================================
  Hits         8332     8332           
  Misses       1826     1826           
Flag Coverage Δ
unittests 82.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inomdzhon inomdzhon merged commit 070e4eb into master Jan 29, 2024
27 checks passed
@inomdzhon inomdzhon deleted the imirdzhamolov/issue3521/fix/SimpleCell-indicator-prop branch January 29, 2024 09:48
vkcom-publisher pushed a commit that referenced this pull request Jan 29, 2024
Приоритезируем размер indicator за счёт flex-shirk: 0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Наполовину не видно indicator у SimpleCell
3 participants