fix(ModalPage): account for prev expandable value #6637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
patch
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit f72dd9d |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6637 +/- ##
=======================================
Coverage 82.20% 82.20%
=======================================
Files 331 331
Lines 10219 10219
Branches 3422 3421 -1
=======================================
Hits 8401 8401
Misses 1818 1818
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SevereCloud
approved these changes
Feb 27, 2024
inomdzhon
approved these changes
Feb 27, 2024
vkcom-publisher
pushed a commit
that referenced
this pull request
Feb 28, 2024
* fix(ModalPage): apply DOM changes before height calculation * fix(ModalPage): apply DOM changes before height calculation
BlackySoul
added a commit
that referenced
this pull request
Feb 28, 2024
* fix(ModalPage): apply DOM changes before height calculation * fix(ModalPage): apply DOM changes before height calculation
Merged
BlackySoul
added a commit
that referenced
this pull request
Feb 28, 2024
vkcom-publisher
pushed a commit
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Изменения
Смотрим на предыдущее значение
expandableдля принятия решения по разворачиванию модалки - если изначально модалку нельзя было открыть на всю высоту, то оставляем её в свернутом состоянии