Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(snackbar): compensate bottom margin #6659

Merged
merged 2 commits into from
Mar 19, 2024
Merged

feat(snackbar): compensate bottom margin #6659

merged 2 commits into from
Mar 19, 2024

Conversation

akcent1132
Copy link
Contributor

@akcent1132 akcent1132 commented Mar 5, 2024 •
edited
Loading

Описание

Скомпенсировать снизу отступ action внутри snackbar

Изменения

Выровнял отступ
загруженное

@akcent1132 akcent1132 requested a review from a team as a code owner March 5, 2024 00:04
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Mar 5, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024 •
edited
Loading

e2e tests

Playwright Report

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024 •
edited
Loading

👀 Docs deployed

Commit f1171d2

@codecov Codecov
Copy link

codecov bot commented Mar 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.36%. Comparing base (cdb6723) to head (f1171d2).

❗ Current head f1171d2 differs from pull request most recent head 9607ac2. Consider uploading reports for the commit 9607ac2 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6659   +/-   ##
=======================================
  Coverage   82.35%   82.36%           
=======================================
  Files         335      335           
  Lines       10332    10336    +4     
  Branches     3461     3463    +2     
=======================================
+ Hits         8509     8513    +4     
  Misses       1823     1823
Flag Coverage Δ
unittests 82.36% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

inomdzhon
inomdzhon reviewed Mar 7, 2024
View reviewed changes
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо за правку ✨

Решение имеет место быть, но из-за того, что у нас значения отступов "динамичные" и параметр action может быть не передан, нужно более универсальное решение.

packages/vkui/src/components/Snackbar/subcomponents/Basic/Basic.module.css Outdated Show resolved Hide resolved
@akcent1132 akcent1132 force-pushed the feat/snackbar/same-margin-inside-button branch from 507809a to 028ea54 Compare March 12, 2024 18:26
@akcent1132 akcent1132 changed the title feat(snackbar): make the same vertical margin by bottom offset feat(snackbar): compensate bottom margin Mar 12, 2024
inomdzhon
inomdzhon reviewed Mar 13, 2024
View reviewed changes
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝

PS: закрался пустой блок с комментариям – можешь нажать на "Apply suggestion", чтобы быстрей зарезолвить коммент

packages/vkui/src/components/Snackbar/Snackbar.tsx Outdated Show resolved Hide resolved
@SevereCloud SevereCloud requested a review from inomdzhon March 14, 2024 07:31
inomdzhon
inomdzhon previously approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mendrew
mendrew previously approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

SevereCloud
SevereCloud requested changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@SevereCloud SevereCloud left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нужно поправить пару моментов

packages/vkui/src/components/Snackbar/Snackbar.module.css Outdated Show resolved Hide resolved
packages/vkui/src/components/Snackbar/Snackbar.tsx Outdated Show resolved Hide resolved
@akcent1132 akcent1132 dismissed stale reviews from inomdzhon and mendrew via da8f6a2 March 14, 2024 13:23
@akcent1132 akcent1132 force-pushed the feat/snackbar/same-margin-inside-button branch 2 times, most recently from b784c9e to d48acdd Compare March 14, 2024 13:43
inomdzhon
inomdzhon reviewed Mar 15, 2024
View reviewed changes
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Сорри, проглядел, что надо было в Snackbar.Basic манипуляции делать :(

Спасибо @ SevereCloud, что заметил

packages/vkui/src/components/Snackbar/subcomponents/Basic/Basic.tsx Outdated Show resolved Hide resolved
packages/vkui/src/components/Snackbar/subcomponents/Basic/Basic.tsx Outdated Show resolved Hide resolved
@akcent1132 akcent1132 force-pushed the feat/snackbar/same-margin-inside-button branch from 55d64e7 to c33a334 Compare March 18, 2024 16:47
inomdzhon
inomdzhon approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🙏

@inomdzhon inomdzhon merged commit a3b96b2 into VKCOM:master Mar 19, 2024
1 check passed
@akcent1132
Copy link
Contributor Author

👍 🙏

@inomdzhon @SevereCloud спасибо за подробные пояснительные комменты.

@akcent1132 akcent1132 deleted the feat/snackbar/same-margin-inside-button branch September 23, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SevereCloud SevereCloud SevereCloud approved these changes

@inomdzhon inomdzhon inomdzhon approved these changes

@mendrew mendrew mendrew left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Snackbar скомпенсировать отступ снизу от action
5 participants
@akcent1132 @mendrew @inomdzhon @SevereCloud @actions-user