Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FocusTrap): preventDefault on Escape #6681

Merged

Conversation

SevereCloud
Copy link
Contributor

Описание

В сафари в открытой модалке при нажатии на Esc браузер переходит из развернутого в оконный режим

Изменения

Вызываем preventDefault при нажатии на Esc

@SevereCloud SevereCloud requested a review from a team as a code owner March 11, 2024 15:28
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Mar 11, 2024
@SevereCloud SevereCloud self-assigned this Mar 11, 2024
@SevereCloud SevereCloud added this to the v6.0.2 milestone Mar 11, 2024
Copy link
Contributor

size-limit report 📦

Path Size
JS 353.86 KB (+0.01% 🔺)
JS (gzip) 108.08 KB (+0.01% 🔺)
JS (brotli) 89.48 KB (+0.18% 🔺)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 257.99 KB (0%)
CSS (gzip) 33.81 KB (0%)
CSS (brotli) 27.44 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit f4ac116

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.25%. Comparing base (83462f2) to head (f4ac116).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6681   +/-   ##
=======================================
  Coverage   82.24%   82.25%           
=======================================
  Files         331      331           
  Lines       10270    10271    +1     
  Branches     3439     3439           
=======================================
+ Hits         8447     8448    +1     
  Misses       1823     1823           
Flag Coverage Δ
unittests 82.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlackySoul
Copy link
Contributor

Скриншот завалился 🤔

@inomdzhon
Copy link
Contributor

Скриншот завалился 🤔

он там именно флакнул – выглядит как изредка допустимая история

@SevereCloud SevereCloud merged commit 9fec797 into master Mar 13, 2024
27 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/fix/FocusTrap/preventDefault-on-Escape branch March 13, 2024 08:25
@vkcom-publisher
Copy link
Contributor

v6.0.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants