-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(FocusTrap): preventDefault on Escape #6681
fix(FocusTrap): preventDefault on Escape #6681
Conversation
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests
|
👀 Docs deployed
Commit f4ac116 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6681 +/- ##
=======================================
Coverage 82.24% 82.25%
=======================================
Files 331 331
Lines 10270 10271 +1
Branches 3439 3439
=======================================
+ Hits 8447 8448 +1
Misses 1823 1823
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Скриншот завалился 🤔 |
он там именно флакнул – выглядит как изредка допустимая история |
✅ v6.0.2 🎉 |
Описание
В сафари в открытой модалке при нажатии на Esc браузер переходит из развернутого в оконный режим
Изменения
Вызываем
preventDefault
при нажатии на Esc