fix(Search): correct side margins of after element on iOS
#6724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
На iOS кнопка в after выезжает если есть текст или фокус у инпута. Но пока эта кнопка не видна, она всё ещё влияет на верстку Search, за счёт своих марджинов. Задаём margin только когда кнопка видна.
github-actions
bot
added
the
patch
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 2c86000 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6724 +/- ##
=======================================
Coverage 82.36% 82.36%
=======================================
Files 335 335
Lines 10347 10351 +4
Branches 3466 3467 +1
=======================================
+ Hits 8522 8526 +4
Misses 1825 1825
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
inomdzhon
changed the title
after element on iOsafter element on iOS
inomdzhon
approved these changes
Mar 20, 2024
SevereCloud
approved these changes
Mar 20, 2024
mendrew
deleted the
mendrew/fix/6719/Search/incorrect-side-margins-on-ios
branch
vkcom-publisher
pushed a commit
that referenced
this pull request
Mar 21, 2024
На iOS кнопка в after выезжает если есть текст или фокус у инпута. Но пока эта кнопка не видна, она всё ещё влияет на верстку Search, за счёт своих марджинов. Задаём margin только когда кнопка видна. На анимацию появления это никак не повлияло.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
На
iOSкнопка вafterвыезжает если есть текст или фокус у инпута.Но пока эта кнопка не видна, она всё ещё влияет на верстку
Search, за счёт своих марджинов.Задаём
marginтолько когда кнопка видна.На анимацию появления это никак не повлияло.
Изображения
Diff из Playwright для демонстрации до и после:
