-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ModalPageHeader): Широкий сепаратор в режиме regular #6726
fix(ModalPageHeader): Широкий сепаратор в режиме regular #6726
Conversation
In compact mode we should draw separtor with paddings In regular it should be wide
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 466688f |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6726 +/- ##
=======================================
Coverage 82.36% 82.36%
=======================================
Files 335 335
Lines 10347 10351 +4
Branches 3466 3467 +1
=======================================
+ Hits 8522 8526 +4
Misses 1825 1825
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
После f7c9098 мы стали рисовать сепаратор независимо от платформы, но судя по дизайну широкий сепаратор нужен только в режиме regular.
Описание
После f7c9098 мы стали рисовать сепаратор независимо от платформы, но судя по дизайну широкий сепаратор нужен только в режиме regular.
Изображения