Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ModalPageHeader): Широкий сепаратор в режиме regular #6726

Merged

Conversation

mendrew
Copy link
Contributor

@mendrew mendrew commented Mar 20, 2024


  • Дизайн-ревью

Описание

После f7c9098 мы стали рисовать сепаратор независимо от платформы, но судя по дизайну широкий сепаратор нужен только в режиме regular.

Изображения

До После
Regular Screenshot 2024-03-26 at 10 48 03 Screenshot 2024-03-26 at 10 47 24

In compact mode we should draw separtor with paddings
In regular it should be wide
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Mar 20, 2024
Copy link
Contributor

github-actions bot commented Mar 20, 2024

size-limit report 📦

Path Size
JS 356.9 KB (+0.01% 🔺)
JS (gzip) 108.94 KB (+0.01% 🔺)
JS (brotli) 90.08 KB (+0.03% 🔺)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 261.8 KB (0%)
CSS (gzip) 34.36 KB (0%)
CSS (brotli) 27.86 KB (0%)

Copy link

codesandbox-ci bot commented Mar 20, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Mar 20, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Mar 20, 2024

👀 Docs deployed

Commit 466688f

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.36%. Comparing base (a3b96b2) to head (466688f).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6726   +/-   ##
=======================================
  Coverage   82.36%   82.36%           
=======================================
  Files         335      335           
  Lines       10347    10351    +4     
  Branches     3466     3467    +1     
=======================================
+ Hits         8522     8526    +4     
  Misses       1825     1825           
Flag Coverage Δ
unittests 82.36% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mendrew mendrew marked this pull request as ready for review March 21, 2024 09:41
@mendrew mendrew requested a review from a team as a code owner March 21, 2024 09:41
@mendrew mendrew requested a review from a team March 25, 2024 09:23
@mendrew mendrew changed the title fix(ModalPageHeader): Fix separator spacing fix(ModalPageHeader): Широкий сепаратор в режиме regular Mar 26, 2024
Copy link

@Zaycevq Zaycevq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@mendrew mendrew merged commit 1c79e53 into master Mar 26, 2024
26 checks passed
@mendrew mendrew deleted the mendrew/fix/6722/ModalPageHeader/fix-separator-spacing branch March 26, 2024 12:05
vkcom-publisher pushed a commit that referenced this pull request Mar 26, 2024
После f7c9098 мы стали рисовать сепаратор независимо от платформы, но судя по дизайну широкий сепаратор нужен только в режиме regular.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Некорректные боковые оступы у сепаратора ModalPageHeader
5 participants