Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ActionSheetItem padding-inline: 16px #6813

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Apr 10, 2024


  • Дизайн-ревью

Описание

Отступ для ActionSheetItem должен быть 16px, а не 20зx

Изменения

Меняем отступы, в том числе в заголовках

@SevereCloud SevereCloud requested a review from a team as a code owner April 10, 2024 12:22
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Apr 10, 2024
Copy link
Contributor

size-limit report 📦

Path Size
JS 357.65 KB (0%)
JS (gzip) 109.09 KB (0%)
JS (brotli) 90.16 KB (0%)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 261.75 KB (+0.01% 🔺)
CSS (gzip) 34.37 KB (0%)
CSS (brotli) 27.83 KB (-0.09% 🔽)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 00940fc

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.43%. Comparing base (2bbd5ea) to head (00940fc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6813   +/-   ##
=======================================
  Coverage   82.43%   82.43%           
=======================================
  Files         339      339           
  Lines       10395    10395           
  Branches     3475     3475           
=======================================
  Hits         8569     8569           
  Misses       1826     1826           
Flag Coverage Δ
unittests 82.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@Zaycevq Zaycevq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@SevereCloud SevereCloud merged commit f354850 into master Apr 15, 2024
26 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/issue6812 branch April 15, 2024 11:31
vkcom-publisher pushed a commit that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Изменить отступ для List / Action Sheet – platform [Android]
3 participants