Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SimpleCell): fix before icon offset (iOS) #6829

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

BlackySoul
Copy link
Contributor


  • e2e-тесты

Описание

Для iOS отступ от иконки не должен содержать дополнительные 4px

@BlackySoul BlackySoul requested a review from a team as a code owner April 15, 2024 07:32
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Apr 15, 2024
Copy link
Contributor

github-actions bot commented Apr 15, 2024

size-limit report 📦

Path Size
JS 357.69 KB (+0.02% 🔺)
JS (gzip) 109.1 KB (+0.02% 🔺)
JS (brotli) 90.12 KB (-0.05% 🔽)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 261.8 KB (+0.03% 🔺)
CSS (gzip) 34.37 KB (+0.02% 🔺)
CSS (brotli) 27.84 KB (+0.03% 🔺)

Copy link

codesandbox-ci bot commented Apr 15, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Apr 15, 2024

e2e tests

Playwright Report

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.43%. Comparing base (7f85747) to head (5563539).
Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6829   +/-   ##
=======================================
  Coverage   82.43%   82.43%           
=======================================
  Files         339      339           
  Lines       10395    10396    +1     
  Branches     3475     3476    +1     
=======================================
+ Hits         8569     8570    +1     
  Misses       1826     1826           
Flag Coverage Δ
unittests 82.43% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlackySoul BlackySoul marked this pull request as draft April 18, 2024 15:29
@BlackySoul BlackySoul marked this pull request as ready for review April 18, 2024 15:29
Copy link
Contributor

👀 Docs deployed

Commit 5563539

Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BlackySoul BlackySoul merged commit 2d26ae0 into master Apr 22, 2024
26 checks passed
@BlackySoul BlackySoul deleted the fix/6787/SimpleCell_fix_offsets branch April 22, 2024 08:44
vkcom-publisher pushed a commit that referenced this pull request Apr 22, 2024
* fix(SimpleCell): fix before icon offset (iOS)

* CHORE: Update screenshots

---------

Co-authored-by: GitHub Action <actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Исправить отступ в SimpleCell для состояния с Иконкой [iOS]
4 participants