Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ToolButton #6837

Merged
merged 3 commits into from
May 14, 2024
Merged

feat: add ToolButton #6837

merged 3 commits into from
May 14, 2024

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Apr 16, 2024


  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи

Описание

Добавляем новый вид кнопок

@SevereCloud SevereCloud requested a review from a team as a code owner April 16, 2024 11:31
Copy link
Contributor

github-actions bot commented Apr 16, 2024

size-limit report 📦

Path Size
JS 362.22 KB (+0.3% 🔺)
JS (gzip) 110.07 KB (+0.28% 🔺)
JS (brotli) 90.59 KB (+0.2% 🔺)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 265.99 KB (+1.56% 🔺)
CSS (gzip) 34.72 KB (+0.94% 🔺)
CSS (brotli) 28.11 KB (+0.92% 🔺)

@SevereCloud SevereCloud requested a review from a team April 16, 2024 11:34
Copy link

codesandbox-ci bot commented Apr 16, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Apr 16, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Apr 16, 2024

👀 Docs deployed

Commit b6a5187

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.51%. Comparing base (f354850) to head (b6a5187).
Report is 43 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6837      +/-   ##
==========================================
+ Coverage   82.43%   82.51%   +0.08%     
==========================================
  Files         339      340       +1     
  Lines       10395    10446      +51     
  Branches     3475     3490      +15     
==========================================
+ Hits         8569     8620      +51     
  Misses       1826     1826              
Flag Coverage Δ
unittests 82.51% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mendrew
mendrew previously approved these changes Apr 18, 2024
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Выглядит отлично 💯

Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

Copy link

@EleonoraEvans EleonoraEvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

все ок)

@vkcom-publisher vkcom-publisher added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels May 10, 2024
@SevereCloud SevereCloud merged commit 8ddef8d into master May 14, 2024
26 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/issue6817 branch May 14, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Создать компонент Tool Button
5 participants