Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HorizontalScroll): add inline mode #6848

Merged
merged 3 commits into from
May 3, 2024

Conversation

BlackySoul
Copy link
Contributor


  • e2e-тесты
  • Документация фичи

Изменения

Добавляем проп inline, для возможности располагать потомков горизонтально

Copy link
Contributor

github-actions bot commented Apr 23, 2024

size-limit report 📦

Path Size
JS 358.64 KB (+0.02% 🔺)
JS (gzip) 109.39 KB (+0.03% 🔺)
JS (brotli) 90.41 KB (+0.06% 🔺)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 261.98 KB (+0.03% 🔺)
CSS (gzip) 34.41 KB (+0.03% 🔺)
CSS (brotli) 27.88 KB (+0.09% 🔺)

Copy link

codesandbox-ci bot commented Apr 23, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Apr 23, 2024

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 77a9376

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.48%. Comparing base (caf6d7f) to head (14db5e9).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6848   +/-   ##
=======================================
  Coverage   82.48%   82.48%           
=======================================
  Files         340      340           
  Lines       10426    10428    +2     
  Branches     3481     3483    +2     
=======================================
+ Hits         8600     8602    +2     
  Misses       1826     1826           
Flag Coverage Δ
unittests 82.48% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlackySoul BlackySoul marked this pull request as draft April 23, 2024 14:07
@BlackySoul BlackySoul marked this pull request as ready for review April 23, 2024 14:07
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

в v7 я бы удалил inline, ибо HorizontalScroll предполагает выравнивание потомков в инлайн

@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label May 1, 2024
@BlackySoul BlackySoul removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label May 2, 2024
@BlackySoul BlackySoul merged commit cb24a45 into master May 3, 2024
26 checks passed
@BlackySoul BlackySoul deleted the feat/6845/HorizontalScroll_add_inline_mode branch May 3, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][HorizontalScroll]: Добавить inline проп или сабкомпонент для flex
5 participants