Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TabsItem): add Tappable props #6869

Merged
merged 3 commits into from
May 6, 2024

Conversation

BlackySoul
Copy link
Contributor


Изменения

Добавляем возможность прокидывать некоторые пропы от Tappable

Copy link
Contributor

github-actions bot commented May 2, 2024

size-limit report 📦

Path Size
JS 362.47 KB (+0.06% 🔺)
JS (gzip) 110.18 KB (+0.07% 🔺)
JS (brotli) 90.75 KB (+0.08% 🔺)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 264.84 KB (0%)
CSS (gzip) 34.8 KB (0%)
CSS (brotli) 28.18 KB (0%)

Copy link

codesandbox-ci bot commented May 2, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented May 2, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented May 2, 2024

👀 Docs deployed

Commit 7b2c9df

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.48%. Comparing base (caf6d7f) to head (7b2c9df).
Report is 19 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6869   +/-   ##
=======================================
  Coverage   82.48%   82.48%           
=======================================
  Files         340      340           
  Lines       10426    10428    +2     
  Branches     3481     3487    +6     
=======================================
+ Hits         8600     8602    +2     
  Misses       1826     1826           
Flag Coverage Δ
unittests 82.48% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SevereCloud
SevereCloud previously approved these changes May 2, 2024
inomdzhon
inomdzhon previously approved these changes May 3, 2024
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

выглядит как брейкинг чендж 🤔

@BlackySoul
Copy link
Contributor Author

выглядит как брейкинг чендж 🤔

За счет того, что пользователи могли прокидывать свойства, которые просто не применялись до этого момента?)

@BlackySoul BlackySoul dismissed stale reviews from inomdzhon and SevereCloud via af4fb8b May 3, 2024 10:57
SevereCloud
SevereCloud previously approved these changes May 3, 2024
Co-authored-by: Inomdzhon Mirdzhamolov <i.mirdzhamolov@vk.team>
@BlackySoul BlackySoul merged commit 0760683 into master May 6, 2024
26 checks passed
@BlackySoul BlackySoul deleted the feat/6849/TabsItem_add_tappable branch May 6, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][TabsItem]: Возможность переопределения hoverMode и activeMode
4 participants