Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Cell): rm OUTBOX_OFFSET #6971

Merged
merged 1 commit into from
May 28, 2024

Conversation

inomdzhon
Copy link
Contributor


  • Unit-тесты

Описание

Удаляем проверку на OUTBOX_OFFSET, т.к. из-за неё не срабаывает автоскролл при уводе элемента за область видимости.

- caused by #5833

Удаляем проверку на OUTBOX_OFFSET, т.к. из-за неё нельзя включить автоскролл при уводе элемента за область видимости.
@inomdzhon inomdzhon requested a review from a team as a code owner May 28, 2024 13:55
@inomdzhon inomdzhon self-assigned this May 28, 2024
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label May 28, 2024
@inomdzhon inomdzhon added type:bug cmp:cell and removed patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча labels May 28, 2024
@inomdzhon inomdzhon added this to the v6.1.1 milestone May 28, 2024
Copy link
Contributor

size-limit report 📦

Path Size
JS 363.22 KB (-0.01% 🔽)
JS (gzip) 111.27 KB (-0.02% 🔽)
JS (brotli) 91.51 KB (-0.05% 🔽)
JS import Div (tree shaking) 1.42 KB (0%)
CSS 275.72 KB (0%)
CSS (gzip) 35.93 KB (0%)
CSS (brotli) 29.08 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 3938118

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.38%. Comparing base (5c16556) to head (3938118).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6971      +/-   ##
==========================================
- Coverage   83.38%   83.38%   -0.01%     
==========================================
  Files         352      352              
  Lines       10515    10513       -2     
  Branches     3493     3492       -1     
==========================================
- Hits         8768     8766       -2     
  Misses       1747     1747              
Flag Coverage Δ
unittests 83.38% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SevereCloud SevereCloud added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label May 28, 2024
@inomdzhon inomdzhon merged commit c2a603f into master May 28, 2024
26 checks passed
@inomdzhon inomdzhon deleted the imirdzhamolov/fix/Cell-draggable-outside-area branch May 28, 2024 15:25
vkcom-publisher pushed a commit that referenced this pull request May 28, 2024
- caused by #5833

Удаляем проверку на OUTBOX_OFFSET, т.к. из-за неё нельзя включить автоскролл при уводе элемента за область видимости.
@vkcom-publisher
Copy link
Contributor

v6.1.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmp:cell patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча type:bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants