-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Snackbar): show snackbar always from bottom-start in mobile #7135
refactor(Snackbar): show snackbar always from bottom-start in mobile #7135
Conversation
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 40a22e1 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7135 +/- ##
==========================================
- Coverage 84.07% 84.05% -0.03%
==========================================
Files 359 359
Lines 10909 10893 -16
Branches 3591 3585 -6
==========================================
- Hits 9172 9156 -16
Misses 1737 1737
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cb12cd2
to
4936fd3
Compare
Теперь `placement="bottom-start"`, `placement="bottom"` и `placement="bottom-end"` в мобильном режиме всегда будет показываться слева-направо, чтобы избежать проблемы с вызовом системных поведений, таких как pull-to-refresh и/или режим одного пальца.
4936fd3
to
f03378a
Compare
Co-authored-by: Victoria Zhizhonkova <indarklight@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
❌ PatchНе удалось автоматически применить исправление на ветке 6.2-stable.
Чтобы изменение попало в ветку 6.2-stable, выполните следующие действия:
git stash # опционально
git fetch origin 6.2-stable
git checkout -b patch/pr7135 origin/6.2-stable
git cherry-pick --no-commit 397a971d04485458f9d105e73c644cfb229b7768
git checkout HEAD **/__image_snapshots__/*.png
git diff --quiet HEAD || git commit --no-verify --no-edit
git push --set-upstream origin patch/pr7135
gh pr create --base 6.2-stable --title "patch: pr7135" --body "- patch #7135" |
…7135) Теперь `placement="bottom-start"`, `placement="bottom"` и `placement="bottom-end"` в мобильном режиме всегда будут показываться слева-направо, чтобы избежать проблемы с вызовом системных поведений, таких как pull-to-refresh и/или режим одного пальца.
Описание
Теперь
placement="bottom-start"
,placement="bottom"
иplacement="bottom-end"
в мобильном режиме всегда будут показываться слева-направо, чтобы избежать проблемы с вызовом системных поведений, таких как pull-to-refresh и/или режим одного пальца.