Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(customize.md): fix imports and add additional comments #7205

Merged
merged 2 commits into from
Jul 17, 2024
Merged

docs(customize.md): fix imports and add additional comments #7205

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5de75fd
docs(customize.md): fix imports and add additional comments
inomdzhon Jul 16, 2024
bf463c8
review: apply suggestions
inomdzhon Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions styleguide/pages/customize.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,19 +87,19 @@ ReactDOM.render(
```jsx static
import { ConfigProvider, AppRoot, Button } from '@vkontakte/vkui';
import '@vkontakte/vkui/dist/components.css';
import '@vkontakte/vkui-tokens/themes/paradigmBase/cssVars/declarations/onlyVariables.css';
import '@vkontakte/vkui-tokens/themes/paradigmBaseDark/cssVars/declarations/onlyVariablesLocal.css';
import '@vkontakte/vkui-tokens/themes/paradigmBase/cssVars/declarations/onlyVariables.css'; // базовая тема должна подключаться через `:root`, поэтому здесь импортируется `onlyVariables.css`
inomdzhon marked this conversation as resolved.
Show resolved Hide resolved
import '@vkontakte/vkui-tokens/themes/paradigmBaseDark/cssVars/declarations/onlyVariablesLocal.css'; // остальные должны быть завязаны на CSS класс, поэтому здесь импортируется `onlyVariablesLocal.css`
inomdzhon marked this conversation as resolved.
Show resolved Hide resolved

// раз iOS мы не затрагиваем, то необходимо подключить стили по умолчанию
import '@vkontakte/vkui-tokens/themes/vkIOS/cssVars/declarations/onlyVariables.css';
import '@vkontakte/vkui-tokens/themes/vkIOS/cssVars/declarations/onlyVariablesLocal.css';
import '@vkontakte/vkui-tokens/themes/vkIOSDark/cssVars/declarations/onlyVariablesLocal.css';

ReactDOM.render(
<ConfigProvider
tokensClassNames={{
android: {
light: 'myCustomThemeTokens--appearance-light',
dark: 'myCustomThemeTokens--appearance-dark',
light: 'vkui--paradigmBase--light',
dark: 'vkui--paradigmBase--dark',
},
}}
>
Expand All @@ -120,8 +120,8 @@ import '@vkontakte/vkui/dist/components.css';
import './myCustomThemeTokens.css';

// раз iOS мы не затрагиваем, то необходимо подключить стили по умолчанию
import '@vkontakte/vkui-tokens/themes/myCustomIOS/cssVars/declarations/onlyVariables.css';
import '@vkontakte/vkui-tokens/themes/myCustomIOSDark/cssVars/declarations/onlyVariablesLocal.css';
import '@vkontakte/vkui-tokens/themes/vkIOS/cssVars/declarations/onlyVariablesLocal.css';
import '@vkontakte/vkui-tokens/themes/vkIOSDark/cssVars/declarations/onlyVariablesLocal.css';

ReactDOM.render(
<ConfigProvider
Expand Down