Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y(WriteBar): add onClick to add interactivity #7376

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor


Описание

Нужно сделать кнопки в Writebar в Storybook интерактивными

Изменения

Добавил прокидывание noop колбэка в onClick для кнопок

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner August 13, 2024 10:04
Copy link
Contributor

👀 Docs deployed

Commit c569bfb

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.62%. Comparing base (ae074c5) to head (c569bfb).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7376   +/-   ##
=======================================
  Coverage   92.62%   92.62%           
=======================================
  Files         374      374           
  Lines       11118    11118           
  Branches     3646     3646           
=======================================
  Hits        10298    10298           
  Misses        820      820           
Flag Coverage Δ
unittests 92.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@inomdzhon inomdzhon added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Aug 14, 2024
@inomdzhon inomdzhon merged commit d3858fe into master Aug 14, 2024
17 checks passed
@inomdzhon inomdzhon deleted the e.muhamethanov/a11y/5013/fix-write-bar-a11y branch August 14, 2024 07:32
vkcom-publisher pushed a commit that referenced this pull request Aug 14, 2024
Добавил прокидывание noop колбэка в onClick для кнопок
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs][a11y][WriteBar]: Исправить пример в Storybook
4 participants