fix(ActionSheet): add a11y documentation for ActionSheetItem #7394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
patch
👀 Docs deployed
Commit c4280f6 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7394 +/- ##
==========================================
+ Coverage 92.62% 92.75% +0.12%
==========================================
Files 374 374
Lines 11118 11118
Branches 3646 3646
==========================================
+ Hits 10298 10312 +14
+ Misses 820 806 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
inomdzhon
approved these changes
Aug 20, 2024
vkcom-publisher
pushed a commit
that referenced
this pull request
Aug 20, 2024
h2. Описание Необходимо проверить общую цифровую доступность компонентов `ActionSheet` и `ActionSheetItem`. h2. Изменения - Написал документацию по цифровой доступности для компонента `ActionSheetItem` - Поправил пример с `selectable` элементами в `storybook` - Поменял пример с `selectable` элементами в `styleguide`. Взял из дизайна в фигме - Проверил общую доступность компонента в `styleguide` и `storybook` через `VoiceOver` и `NVDA`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActionSheet#3044Описание
Необходимо проверить общую цифровую доступность компонентов
ActionSheetиActionSheetItem.Изменения
ActionSheetItemselectableэлементами вstorybookselectableэлементами вstyleguide. Взял из дизайна в фигмеstyleguideиstorybookчерезVoiceOverиNVDA