Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove maxHeight props from DateRangeInput, DateInput and CustomSelect #7408

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor

Описание

Убрал проп maxHeight в компонентах DateRangeInput, DateInput и CustomSelect так как он там не нужен и только смущает пользователей

@EldarMuhamethanov EldarMuhamethanov self-assigned this Aug 20, 2024
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner August 20, 2024 07:14
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Aug 20, 2024
Copy link
Contributor

size-limit report 📦

Path Size
JS 377.97 KB (-0.01% 🔽)
JS (gzip) 114.62 KB (-0.01% 🔽)
JS (brotli) 94.03 KB (-0.14% 🔽)
JS import Div (tree shaking) 1.39 KB (0%)
CSS 305.56 KB (0%)
CSS (gzip) 39.21 KB (0%)
CSS (brotli) 31.45 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit c27efef

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.74%. Comparing base (38501e0) to head (c27efef).
Report is 15 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7408   +/-   ##
=======================================
  Coverage   92.74%   92.74%           
=======================================
  Files         374      374           
  Lines       11103    11103           
  Branches     3646     3646           
=======================================
  Hits        10298    10298           
  Misses        805      805           
Flag Coverage Δ
unittests 92.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inomdzhon inomdzhon added this to the v6.5.1 milestone Aug 20, 2024
@mendrew mendrew merged commit 89d6a36 into master Aug 20, 2024
28 checks passed
@mendrew mendrew deleted the e.muhamethanov/remove-max-height-props branch August 20, 2024 12:34
vkcom-publisher pushed a commit that referenced this pull request Aug 20, 2024
…Select (#7408)

Убрал проп maxHeight в компонентах DateRangeInput, DateInput и CustomSelect так как он там не нужен и только смущает пользователей
@vkcom-publisher
Copy link
Contributor

v6.5.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmp:custom-select cmp:date-input cmp:date-range-input patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants