fix(CustomSelect): fix custom select cursor updating #7508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
patch
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 7c78834 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7508 +/- ##
=======================================
Coverage 95.17% 95.17%
=======================================
Files 384 384
Lines 11212 11215 +3
Branches 3674 3676 +2
=======================================
+ Hits 10671 10674 +3
Misses 541 541
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SevereCloud
approved these changes
Sep 2, 2024
andrey-medvedev-vk
deleted the
e.muhamethanov/7504/fix-custom-select-cursor-using
branch
vkcom-publisher
pushed a commit
that referenced
this pull request
Sep 2, 2024
Сейчас нельзя изменять положение курсора с помощью мыши в searchable CustomSelect-е. Проблема в том, что при обработке mousedown происходит preventDefault всегда когда input в фокусе. Нужно доработать проверку так, что при наличии фокуса и клике в input не происходил preventDefault Обработали кейс, чтобы при фокуса в поле просходило выделение всего текста
SevereCloud
added a commit
that referenced
this pull request
Sep 18, 2024
This reverts commit dd77217.
SevereCloud
added a commit
that referenced
this pull request
Sep 19, 2024
vkcom-publisher
pushed a commit
that referenced
this pull request
Sep 19, 2024
vkcom-publisher
pushed a commit
that referenced
this pull request
Sep 19, 2024
SevereCloud
added a commit
that referenced
this pull request
Sep 24, 2024
Merged
SevereCloud
added a commit
that referenced
this pull request
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Сейчас нельзя изменять положение курсора с помощью мыши в searchable CustomSelect-е. Проблема в том, что при обработке mousedown происходит preventDefault всегда когда input в фокусе. Нужно доработать проверку так, что при наличии фокуса и клике в input не происходил preventDefault
Изменения
Доработал проверку в обработчике mouseDown, чтобы можно было менять положение курсора мышью
Обработал кейс, чтобы при фокуса в поле просходило выделение всего текста
Release notes
Исправления