Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Skeleton): use js sync animation #7515

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Sep 3, 2024

  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи (не требуется)
  • Release notes

Описание

Анимация скелетона выглядела не очень

Изменения

Изменена анимация с использованием синхронизации анимации через js

Release notes

Улучшения

  • Skeleton: изменена анимация

@SevereCloud SevereCloud requested a review from a team as a code owner September 3, 2024 11:49
@SevereCloud SevereCloud self-assigned this Sep 3, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

size-limit report 📦

Path Size
JS 382.31 KB (+0.19% 🔺)
JS (gzip) 115.76 KB (+0.26% 🔺)
JS (brotli) 94.89 KB (+0.1% 🔺)
JS import Div (tree shaking) 1.45 KB (0%)
CSS 309.23 KB (-0.05% 🔽)
CSS (gzip) 39.67 KB (-0.05% 🔽)
CSS (brotli) 31.88 KB (+0.07% 🔺)

Copy link

codesandbox-ci bot commented Sep 3, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Sep 3, 2024

👀 Docs deployed

Commit 7e3485b

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 97.72727% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.15%. Comparing base (ad82c81) to head (7e3485b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
packages/vkui/src/components/Skeleton/Skeleton.tsx 97.72% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7515   +/-   ##
=======================================
  Coverage   95.14%   95.15%           
=======================================
  Files         384      384           
  Lines       11224    11267   +43     
  Branches     3686     3693    +7     
=======================================
+ Hits        10679    10721   +42     
- Misses        545      546    +1     
Flag Coverage Δ
unittests 95.15% <97.72%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

packages/vkui/src/components/Skeleton/Skeleton.tsx Outdated Show resolved Hide resolved
Zaycevq
Zaycevq previously approved these changes Sep 10, 2024
Copy link

@Zaycevq Zaycevq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@SevereCloud SevereCloud force-pushed the SevereCloud/feat/Skeleton/use-js-sync-animation branch from 2b7068c to 7e3485b Compare September 10, 2024 09:33
@SevereCloud SevereCloud added this to the v6.7.0 milestone Sep 10, 2024
@SevereCloud SevereCloud merged commit c09e235 into master Sep 10, 2024
27 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/feat/Skeleton/use-js-sync-animation branch September 10, 2024 13:19
@vkcom-publisher
Copy link
Contributor

v6.7.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants