Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Flex, SimpleGrid): swap gap prop elements #7550

Merged
merged 5 commits into from
Sep 17, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Sep 10, 2024

  • Unit-тесты
  • e2e-тесты
  • Документация фичи
  • Release notes

Описание

Сейчас у свойства gap в компонентах Flex и SimpleGrid последовательность отступов такая: [column, row]. Нужно поменять местами и сделать [row, column].
Нужно не забыть добавить кодмоды, чтобы поменять местами row и column

Изменения

  • Поменял последовательность отступов в Flex и SimpleGrid в свойстве gap на [row, column]
  • Написал кодмоды для изменения последовательности в коде
  • Обновил скриншотные тесты
  • Поправил тесты

Release notes

BREAKING CHANGE

  • Flex: изменена последовательность отступов в свойстве gap на [row, column]
    <Flex
      direction="column"
    -  gap={[20, 10]}
    +  gap={[10, 20]}
      align="center"
    >
      <div/>
      <div/>
    </Flex>
  • SimpleGrid: изменена последовательность отступов в свойстве gap на [row, column]
    <SimpleGrid
      columns={2}
    -  gap={[20, 10]}
    +  gap={[10, 20]}
      align="center"
    >
      <div/>
      <div/>
    </SimpleGrid>

Copy link
Contributor

github-actions bot commented Sep 10, 2024

size-limit report 📦

Path Size
JS 385.3 KB (0%)
JS (gzip) 116.5 KB (-0.01% 🔽)
JS (brotli) 95.68 KB (-0.01% 🔽)
JS import Div (tree shaking) 1.45 KB (0%)
CSS 330.78 KB (0%)
CSS (gzip) 41.39 KB (0%)
CSS (brotli) 32.85 KB (0%)

Copy link

codesandbox-ci bot commented Sep 10, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Sep 10, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Sep 10, 2024

👀 Docs deployed

Commit 9381de2

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.21%. Comparing base (25349e4) to head (9381de2).
Report is 50 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7550      +/-   ##
==========================================
+ Coverage   95.14%   95.21%   +0.07%     
==========================================
  Files         384      384              
  Lines       11221    11345     +124     
  Branches     3685     3720      +35     
==========================================
+ Hits        10676    10802     +126     
+ Misses        545      543       -2     
Flag Coverage Δ
unittests 95.21% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EldarMuhamethanov EldarMuhamethanov marked this pull request as ready for review September 16, 2024 12:27
Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Поправишь ещё, пожалуйста, значения в доке Flex и SimpleGrid?

Типа такого.

gap={complexGap ? [columnGap, rowGap] : gap}

@EldarMuhamethanov
Copy link
Contributor Author

Member

Поправил

Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@inomdzhon inomdzhon merged commit f676e88 into master Sep 17, 2024
28 checks passed
@inomdzhon inomdzhon deleted the e.muhamethanov/swap-gap-prop-elements branch September 17, 2024 15:33
@vkcom-publisher
Copy link
Contributor

v7.0.0-beta.0 🎉

@inomdzhon inomdzhon modified the milestones: v7.0.0-beta.0, v7.0.0 Dec 2, 2024
@vkcom-publisher
Copy link
Contributor

v7.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants