-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Flex, SimpleGrid): swap gap prop elements #7550
Conversation
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 9381de2 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7550 +/- ##
==========================================
+ Coverage 95.14% 95.21% +0.07%
==========================================
Files 384 384
Lines 11221 11345 +124
Branches 3685 3720 +35
==========================================
+ Hits 10676 10802 +126
+ Misses 545 543 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Поправишь ещё, пожалуйста, значения в доке Flex и SimpleGrid?
Типа такого.
gap={complexGap ? [columnGap, rowGap] : gap} |
Поправил |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
✅ v7.0.0-beta.0 🎉 |
✅ v7.0.0 🎉 |
Описание
Сейчас у свойства
gap
в компонентахFlex
иSimpleGrid
последовательность отступов такая:[column, row]
. Нужно поменять местами и сделать[row, column]
.Нужно не забыть добавить кодмоды, чтобы поменять местами row и column
Изменения
Flex
иSimpleGrid
в свойствеgap
на[row, column]
Release notes
BREAKING CHANGE
gap
на[row, column]
gap
на[row, column]