feat(DisplayTitle): Add adaptivity to DisplayTitle #7553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
patch
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit fd06bd7 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7553 +/- ##
==========================================
+ Coverage 95.14% 95.15% +0.01%
==========================================
Files 384 384
Lines 11224 11273 +49
Branches 3686 3697 +11
==========================================
+ Hits 10679 10727 +48
- Misses 545 546 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andrey-medvedev-vk
removed
the
patch
andrey-medvedev-vk
changed the title
inomdzhon
reviewed
Sep 11, 2024
packages/vkui/src/components/Typography/DisplayTitle/DisplayTitle.tsx
Outdated
Show resolved
Hide resolved
…tle.tsx no-useless-computed-key Co-authored-by: Inomdzhon Mirdzhamolov <i.mirdzhamolov@vk.team>
inomdzhon
approved these changes
Sep 11, 2024
SevereCloud
approved these changes
Sep 11, 2024
8 tasks
| ✅ v6.7.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Добавили compact режим для DisplayTitle, чтобы в теме, где указаты токены compact режима, они применялись.
Падение e2e-тестов
Тесты упали на платформе vkcom, потом что там применяются разные режимы адаптивности, в том числе sizeY: compact. В этом режиме теперь используются compact токены. Раньше такого не было, потому что мы compact режим не обрабатывали.
VKUI/packages/vkui/src/testing/e2e/ComponentPlayground.tsx
Lines 43 to 44 in b43b961
Release notes
Улучшения