-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rename Header and Spinner size prop values #7567
feat: rename Header and Spinner size prop values #7567
Conversation
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 932300e |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7567 +/- ##
=======================================
Coverage 95.21% 95.21%
=======================================
Files 384 384
Lines 11345 11345
Branches 3720 3720
=======================================
Hits 10802 10802
Misses 543 543
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
# Conflicts: # packages/vkui/src/components/ScreenSpinner/ScreenSpinnerLoader.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Класс 🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Шикарно! 😍 Отличная работа 🤝
Описание
Нужно привести значения параметра
size
в компонентах к единому виду:'s' | 'm' | 'l'
и т.д. Надо поискать компоненты в которомsize
указан в другом формате.Изменения
size
указан в формате'small' | 'medium' | 'large'
и т.д. Нашел только компонентSpinner
иHeader
size
в компонентSpinner
в правильный форматsize
в компонентHeader
в правильный форматHeader
Spinner
иHeader
для ремапинга старого форматаsize
в новыйRelease notes
BREAKING CHANGE
size
с'regular' | 'large'
на'm' | 'l'
size
с'small' | 'regular' | 'medium' | 'large'
на's' | 'm' | 'l' | 'xl'