Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename Header and Spinner size prop values #7567

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Sep 11, 2024


  • e2e-тесты
  • Release notes

Описание

Нужно привести значения параметра size в компонентах к единому виду: 's' | 'm' | 'l' и т.д. Надо поискать компоненты в котором size указан в другом формате.

Изменения

  • Поискал компоненты, в которых size указан в формате 'small' | 'medium' | 'large' и т.д. Нашел только компонент Spinner и Header
  • Поменял формат пропа size в компонент Spinner в правильный формат
  • Поменял формат пропа size в компонент Header в правильный формат
  • Обновил скришоты для компонент Header
  • Реализовал кодмоды для компонентов Spinner и Header для ремапинга старого формата size в новый

Release notes

BREAKING CHANGE

  • Header: изменен формат size с 'regular' | 'large' на 'm' | 'l'
    - <Header mode="primary" size="large">
    + <Header mode="primary" size="l">
      Большой заголовок
    </Header>
  • Spinner: изменен формат size с 'small' | 'regular' | 'medium' | 'large' на 's' | 'm' | 'l' | 'xl'
    - <Spinner size="large" />
    + <Spinner size="xl" />
    - <Spinner size="medium" />
    + <Spinner size="l" />
    - <Spinner size="regular" />
    + <Spinner size="m" />
    - <Spinner size="small" />
    + <Spinner size="s" />

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner September 11, 2024 10:00
@EldarMuhamethanov EldarMuhamethanov marked this pull request as draft September 11, 2024 10:00
Copy link
Contributor

github-actions bot commented Sep 11, 2024

size-limit report 📦

Path Size
JS 385.23 KB (-0.02% 🔽)
JS (gzip) 116.48 KB (-0.02% 🔽)
JS (brotli) 95.64 KB (-0.06% 🔽)
JS import Div (tree shaking) 1.45 KB (0%)
CSS 330.78 KB (0%)
CSS (gzip) 41.39 KB (0%)
CSS (brotli) 32.85 KB (0%)

Copy link

codesandbox-ci bot commented Sep 11, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Sep 11, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Sep 11, 2024

👀 Docs deployed

Commit 932300e

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.21%. Comparing base (cc8faef) to head (932300e).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7567   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files         384      384           
  Lines       11345    11345           
  Branches     3720     3720           
=======================================
  Hits        10802    10802           
  Misses        543      543           
Flag Coverage Δ
unittests 95.21% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EldarMuhamethanov EldarMuhamethanov added this to the v7.0.0 milestone Sep 11, 2024
# Conflicts:
#	packages/vkui/src/components/ScreenSpinner/ScreenSpinnerLoader.tsx
@EldarMuhamethanov EldarMuhamethanov marked this pull request as ready for review September 16, 2024 12:27
Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Класс 🥇

Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Шикарно! 😍 Отличная работа 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][7.0.0]: Привести значения size к единому виду
4 participants